firestore: verify DOMException exists before using it in when base64 decoding #7130

dconeybe · 2023-03-16T14:56:32Z

In #7115 the customer shows that the "browser" logic for decoding a base64 string was being invoked from a react-native app. In react-native, the DOMException class does not exist, which results in the following error:

ReferenceError: Property 'DOMException' doesn't exist

This usage of DOMException was added by #7019.

Although a react-native app should be using a different implementation of base64 decoding, we may as well be safe here so that the error message produced from a react-native app is more meaningful, something like Uncaught ReferenceError: atob() is not defined.

changeset-bot · 2023-03-16T14:56:36Z

🦋 Changeset detected

Latest commit: fa2146b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/firestore	Patch
firebase	Patch
@firebase/firestore-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2023-03-16T15:20:13Z

Size Report ¹

Affected Products

@firebase/firestore
Type Base (a8be6ed) Merge (2754c2b) Diff
browser 278 kB 278 kB +33 B (+0.0%)
esm5 346 kB 346 kB +33 B (+0.0%)
module 278 kB 278 kB +33 B (+0.0%)
@firebase/firestore-lite
Type Base (a8be6ed) Merge (2754c2b) Diff
browser 87.7 kB 87.7 kB +33 B (+0.0%)
esm5 106 kB 106 kB +33 B (+0.0%)
module 87.7 kB 87.7 kB +33 B (+0.0%)

`bundle`

12 size changes

Type	Base (`a8be6ed`)	Merge (`2754c2b`)	Diff
firestore (Persistence)	283 kB	283 kB	+33 B (+0.0%)
firestore (Query Cursors)	222 kB	222 kB	+33 B (+0.0%)
firestore (Query)	219 kB	219 kB	+33 B (+0.0%)
firestore (Read data once)	207 kB	207 kB	+33 B (+0.0%)
firestore (Realtime updates)	209 kB	209 kB	+33 B (+0.0%)
firestore (Transaction)	190 kB	190 kB	+33 B (+0.0%)
firestore (Write data)	190 kB	190 kB	+33 B (+0.0%)
firestore-lite (Query Cursors)	81.6 kB	81.6 kB	+33 B (+0.0%)
firestore-lite (Query)	77.7 kB	77.8 kB	+33 B (+0.0%)
firestore-lite (Read data once)	59.9 kB	59.9 kB	+33 B (+0.1%)
firestore-lite (Transaction)	84.7 kB	84.7 kB	+33 B (+0.0%)
firestore-lite (Write data)	69.5 kB	69.6 kB	+33 B (+0.0%)

`firebase`

Type	Base (`a8be6ed`)	Merge (`2754c2b`)	Diff
firebase-compat.js	750 kB	750 kB	+33 B (+0.0%)
firebase-firestore-compat.js	323 kB	323 kB	+33 B (+0.0%)
firebase-firestore-lite.js	94.4 kB	94.5 kB	+33 B (+0.0%)
firebase-firestore.js	327 kB	327 kB	+33 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/vldPbJQND9.html

google-oss-bot · 2023-03-16T15:33:45Z

Size Analysis Report ¹

Affected Products

@firebase/firestore
- AbstractUserDataWriter
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 24.6 kB 24.7 kB +33 B (+0.1%)
  size-with-ext-deps 83.6 kB 83.6 kB +33 B (+0.0%)
- Bytes
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 18.2 kB 18.2 kB +33 B (+0.2%)
  size-with-ext-deps 77.1 kB 77.1 kB +33 B (+0.0%)
- QueryEndAtConstraint
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 35.5 kB 35.5 kB +33 B (+0.1%)
  size-with-ext-deps 94.4 kB 94.5 kB +33 B (+0.0%)
- QueryFieldFilterConstraint
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 41.1 kB 41.1 kB +33 B (+0.1%)
  size-with-ext-deps 100 kB 100 kB +33 B (+0.0%)
- QueryStartAtConstraint
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 35.5 kB 35.5 kB +33 B (+0.1%)
  size-with-ext-deps 94.4 kB 94.5 kB +33 B (+0.0%)
- Transaction
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 50.3 kB 50.4 kB +33 B (+0.1%)
  size-with-ext-deps 109 kB 109 kB +33 B (+0.0%)
- WriteBatch
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 47.2 kB 47.2 kB +33 B (+0.1%)
  size-with-ext-deps 106 kB 106 kB +33 B (+0.0%)
- addDoc
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 120 kB 120 kB +33 B (+0.0%)
  size-with-ext-deps 180 kB 180 kB +33 B (+0.0%)
- aggregateQuerySnapshotEqual
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 32.9 kB 33.0 kB +33 B (+0.1%)
  size-with-ext-deps 92.3 kB 92.3 kB +33 B (+0.0%)
- and
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 42.6 kB 42.6 kB +33 B (+0.1%)
  size-with-ext-deps 102 kB 102 kB +33 B (+0.0%)
- arrayRemove
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 29.4 kB 29.4 kB +33 B (+0.1%)
  size-with-ext-deps 88.3 kB 88.4 kB +33 B (+0.0%)
- arrayUnion
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 29.4 kB 29.4 kB +33 B (+0.1%)
  size-with-ext-deps 88.3 kB 88.4 kB +33 B (+0.0%)
- deleteDoc
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 111 kB 111 kB +33 B (+0.0%)
  size-with-ext-deps 171 kB 171 kB +33 B (+0.0%)
- disableNetwork
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 99.5 kB 99.5 kB +33 B (+0.0%)
  size-with-ext-deps 159 kB 159 kB +33 B (+0.0%)
- enableIndexedDbPersistence
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 181 kB 181 kB +33 B (+0.0%)
  size-with-ext-deps 242 kB 242 kB +33 B (+0.0%)
- enableMultiTabIndexedDbPersistence
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 214 kB 214 kB +33 B (+0.0%)
  size-with-ext-deps 275 kB 275 kB +33 B (+0.0%)
- enableNetwork
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 99.4 kB 99.5 kB +33 B (+0.0%)
  size-with-ext-deps 159 kB 159 kB +33 B (+0.0%)
- endAt
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 35.5 kB 35.5 kB +33 B (+0.1%)
  size-with-ext-deps 94.5 kB 94.5 kB +33 B (+0.0%)
- endBefore
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 35.5 kB 35.5 kB +33 B (+0.1%)
  size-with-ext-deps 94.5 kB 94.5 kB +33 B (+0.0%)
- executeWrite
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 110 kB 110 kB +33 B (+0.0%)
  size-with-ext-deps 170 kB 170 kB +33 B (+0.0%)
- getAggregateFromServer
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 107 kB 107 kB +33 B (+0.0%)
  size-with-ext-deps 166 kB 166 kB +33 B (+0.0%)
- getCountFromServer
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 107 kB 107 kB +33 B (+0.0%)
  size-with-ext-deps 167 kB 167 kB +33 B (+0.0%)
- getDoc
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 137 kB 137 kB +33 B (+0.0%)
  size-with-ext-deps 196 kB 196 kB +33 B (+0.0%)
- getDocFromCache
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 92.2 kB 92.2 kB +33 B (+0.0%)
  size-with-ext-deps 151 kB 151 kB +33 B (+0.0%)
- getDocFromServer
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 137 kB 137 kB +33 B (+0.0%)
  size-with-ext-deps 196 kB 196 kB +33 B (+0.0%)
- getDocs
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 138 kB 138 kB +33 B (+0.0%)
  size-with-ext-deps 198 kB 198 kB +33 B (+0.0%)
- getDocsFromCache
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 99.9 kB 99.9 kB +33 B (+0.0%)
  size-with-ext-deps 159 kB 159 kB +33 B (+0.0%)
- getDocsFromServer
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 138 kB 138 kB +33 B (+0.0%)
  size-with-ext-deps 198 kB 198 kB +33 B (+0.0%)
- loadBundle
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 109 kB 109 kB +33 B (+0.0%)
  size-with-ext-deps 168 kB 168 kB +33 B (+0.0%)
- memoryLocalCache
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 96.4 kB 96.5 kB +33 B (+0.0%)
  size-with-ext-deps 156 kB 156 kB +33 B (+0.0%)
- namedQuery
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 85.6 kB 85.7 kB +33 B (+0.0%)
  size-with-ext-deps 145 kB 145 kB +33 B (+0.0%)
- onSnapshot
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 139 kB 139 kB +33 B (+0.0%)
  size-with-ext-deps 199 kB 199 kB +33 B (+0.0%)
- onSnapshotsInSync
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 129 kB 129 kB +33 B (+0.0%)
  size-with-ext-deps 188 kB 188 kB +33 B (+0.0%)
- or
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 42.6 kB 42.6 kB +33 B (+0.1%)
  size-with-ext-deps 102 kB 102 kB +33 B (+0.0%)
- persistentLocalCache
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 178 kB 178 kB +33 B (+0.0%)
  size-with-ext-deps 239 kB 239 kB +33 B (+0.0%)
- persistentMultipleTabManager
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 211 kB 211 kB +33 B (+0.0%)
  size-with-ext-deps 272 kB 272 kB +33 B (+0.0%)
- persistentSingleTabManager
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 178 kB 178 kB +33 B (+0.0%)
  size-with-ext-deps 239 kB 239 kB +33 B (+0.0%)
- query
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 42.8 kB 42.9 kB +33 B (+0.1%)
  size-with-ext-deps 102 kB 102 kB +33 B (+0.0%)
- queryEqual
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 32.8 kB 32.9 kB +33 B (+0.1%)
  size-with-ext-deps 91.8 kB 91.9 kB +33 B (+0.0%)
- runTransaction
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 120 kB 120 kB +33 B (+0.0%)
  size-with-ext-deps 180 kB 180 kB +33 B (+0.0%)
- setDoc
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 119 kB 119 kB +33 B (+0.0%)
  size-with-ext-deps 179 kB 179 kB +33 B (+0.0%)
- setIndexConfiguration
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 88.3 kB 88.3 kB +33 B (+0.0%)
  size-with-ext-deps 147 kB 147 kB +33 B (+0.0%)
- snapshotEqual
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 38.5 kB 38.6 kB +33 B (+0.1%)
  size-with-ext-deps 97.5 kB 97.6 kB +33 B (+0.0%)
- startAfter
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 35.5 kB 35.5 kB +33 B (+0.1%)
  size-with-ext-deps 94.5 kB 94.5 kB +33 B (+0.0%)
- startAt
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 35.5 kB 35.5 kB +33 B (+0.1%)
  size-with-ext-deps 94.5 kB 94.5 kB +33 B (+0.0%)
- updateDoc
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 120 kB 120 kB +33 B (+0.0%)
  size-with-ext-deps 179 kB 179 kB +33 B (+0.0%)
- waitForPendingWrites
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 99.9 kB 99.9 kB +33 B (+0.0%)
  size-with-ext-deps 159 kB 159 kB +33 B (+0.0%)
- where
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 41.9 kB 41.9 kB +33 B (+0.1%)
  size-with-ext-deps 101 kB 101 kB +33 B (+0.0%)
- writeBatch
  Size
  Type Base (a8be6ed) Merge (2754c2b) Diff
  size 122 kB 122 kB +33 B (+0.0%)
  size-with-ext-deps 181 kB 181 kB +33 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/xdySuE86ZN.html

…decoding (#7130)

dconeybe added 2 commits March 16, 2023 10:48

Check typeof DOMException !== 'undefined'

9c12d71

yarn changeset

fa2146b

dconeybe added the api: firestore label Mar 16, 2023

dconeybe self-assigned this Mar 16, 2023

dconeybe requested a review from milaGGL March 16, 2023 17:56

milaGGL approved these changes Mar 16, 2023

View reviewed changes

dconeybe merged commit 7d23aa4 into master Mar 16, 2023

dconeybe deleted the dconeybe/rn_domexception_fix branch March 16, 2023 18:25

dconeybe mentioned this pull request Mar 16, 2023

Bug, firestore not working with react-native 0.71.3 #7115

Closed

renkelvin pushed a commit that referenced this pull request Mar 21, 2023

firestore: verify DOMException exists before using it in when base64 …

314b1f6

…decoding (#7130)

dwyfrequency pushed a commit that referenced this pull request Mar 23, 2023

firestore: verify DOMException exists before using it in when base64 …

1794678

…decoding (#7130)

google-oss-bot mentioned this pull request Mar 29, 2023

Version Packages #7166

Merged

firebase locked and limited conversation to collaborators Apr 16, 2023

firestore: verify DOMException exists before using it in when base64 decoding #7130

firestore: verify DOMException exists before using it in when base64 decoding #7130

Conversation

dconeybe commented Mar 16, 2023

changeset-bot bot commented Mar 16, 2023

🦋 Changeset detected

google-oss-bot commented Mar 16, 2023

Size Report 1

Affected Products

@firebase/firestore

@firebase/firestore-lite

bundle

firebase

Test Logs

google-oss-bot commented Mar 16, 2023

Size Analysis Report 1

Affected Products

@firebase/firestore

AbstractUserDataWriter

Bytes

QueryEndAtConstraint

QueryFieldFilterConstraint

QueryStartAtConstraint

Transaction

WriteBatch

addDoc

aggregateQuerySnapshotEqual

and

arrayRemove

arrayUnion

deleteDoc

disableNetwork

enableIndexedDbPersistence

enableMultiTabIndexedDbPersistence

enableNetwork

endAt

endBefore

executeWrite

getAggregateFromServer

getCountFromServer

getDoc

getDocFromCache

getDocFromServer

getDocs

getDocsFromCache

getDocsFromServer

loadBundle

memoryLocalCache

namedQuery

onSnapshot

onSnapshotsInSync

or

persistentLocalCache

persistentMultipleTabManager

persistentSingleTabManager

query

queryEqual

runTransaction

setDoc

setIndexConfiguration

snapshotEqual

startAfter

startAt

updateDoc

waitForPendingWrites

where

writeBatch

Test Logs

Size Report ¹

`@firebase/firestore`

`@firebase/firestore-lite`

`bundle`

`firebase`

Size Analysis Report ¹

`@firebase/firestore`

`AbstractUserDataWriter`

`Bytes`

`QueryEndAtConstraint`

`QueryFieldFilterConstraint`

`QueryStartAtConstraint`

`Transaction`

`WriteBatch`

`addDoc`

`aggregateQuerySnapshotEqual`

`and`

`arrayRemove`

`arrayUnion`

`deleteDoc`

`disableNetwork`

`enableIndexedDbPersistence`

`enableMultiTabIndexedDbPersistence`

`enableNetwork`

`endAt`

`endBefore`

`executeWrite`

`getAggregateFromServer`

`getCountFromServer`

`getDoc`

`getDocFromCache`

`getDocFromServer`

`getDocs`

`getDocsFromCache`

`getDocsFromServer`

`loadBundle`

`memoryLocalCache`

`namedQuery`

`onSnapshot`

`onSnapshotsInSync`

`or`

`persistentLocalCache`

`persistentMultipleTabManager`

`persistentSingleTabManager`

`query`

`queryEqual`

`runTransaction`

`setDoc`

`setIndexConfiguration`

`snapshotEqual`

`startAfter`

`startAt`

`updateDoc`

`waitForPendingWrites`

`where`

`writeBatch`