Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unimplemented error when loading bundles #7058

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Fix unimplemented error when loading bundles #7058

merged 2 commits into from
Feb 23, 2023

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Feb 23, 2023 •
edited

Fixes: #5838

Was introduced by: #4098

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2023 •
edited

🦋 Changeset detected

Latest commit: 8cb5449

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wu-hui wu-hui requested a review from ehsannas February 23, 2023 16:22
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 23, 2023 •
edited

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (36558bd)Merge (a1c4d6f)Diff
    browser274 kB274 kB-14 B (-0.0%)
    esm5341 kB341 kB-14 B (-0.0%)
    main548 kB548 kB-14 B (-0.0%)
    module274 kB274 kB-14 B (-0.0%)
    react-native274 kB274 kB-14 B (-0.0%)

  • firebase

    TypeBase (36558bd)Merge (a1c4d6f)Diff
    firebase-compat.js747 kB747 kB-14 B (-0.0%)
    firebase-firestore-compat.js321 kB321 kB-14 B (-0.0%)
    firebase-firestore.js323 kB323 kB-14 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4C9hcRcQRL.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 23, 2023 •
edited

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • loadBundle

      Size

      TypeBase (36558bd)Merge (9adaa5f)Diff
      size107 kB107 kB-14 B (-0.0%)
      size-with-ext-deps166 kB166 kB-14 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/amcrPON1Fh.html

ehsannas
ehsannas approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have a bundles test that could catch this?

@wu-hui
Copy link
Contributor Author

wu-hui commented Feb 23, 2023

Could we have a bundles test that could catch this?

It seems the error only occurs when user get ArrayBuffer from fetch's response, which we do not test.

@wu-hui wu-hui merged commit b30186f into master Feb 23, 2023
@wu-hui wu-hui deleted the wuandy/StreamCloseFix branch February 23, 2023 18:43
@google-oss-bot google-oss-bot mentioned this pull request Mar 1, 2023
Merged
renkelvin pushed a commit that referenced this pull request Mar 2, 2023
@wu-hui
Fix unimplemented error when loading bundles (#7058)
accb682 
* Fix unimplemented error

* Create soft-nails-give.md
@firebase firebase locked and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas approved these changes

Assignees

@ehsannas ehsannas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncaught (in promise) unimplemented being thrown when calling loadBundle from firebase/firestore
3 participants
@wu-hui @google-oss-bot @ehsannas