Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose TOKEN_EXPIRED error upon mfa unenroll. #6973

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Expose TOKEN_EXPIRED error upon mfa unenroll. #6973

merged 2 commits into from
Jan 24, 2023

Conversation

prameshj
Copy link
Contributor

This can be thrown if the MFA option that was most recently enrolled into, was unenrolled. The user will be logged out to prove the posession of the other second factor. This error can be handled by reauthenticating the user.

This change also updates the demo app to store the lastUser in case mfa unenroll logs out the user. From here, the lastUser can be reauthenticated.

@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 6d22568

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 24, 2023 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (4604b3c)Merge (f190613)Diff
    browser157 kB156 kB-75 B (-0.0%)
    cordova184 kB184 kB-98 B (-0.1%)
    esm5205 kB205 kB-98 B (-0.0%)
    main149 kB148 kB-98 B (-0.1%)
    module157 kB156 kB-75 B (-0.0%)
    react-native168 kB168 kB-98 B (-0.1%)

  • @firebase/auth/cordova

    TypeBase (4604b3c)Merge (f190613)Diff
    browser184 kB184 kB-98 B (-0.1%)
    module184 kB184 kB-98 B (-0.1%)

  • @firebase/auth/internal

    TypeBase (4604b3c)Merge (f190613)Diff
    browser167 kB167 kB-75 B (-0.0%)
    esm5218 kB218 kB-98 B (-0.0%)
    main184 kB184 kB-98 B (-0.1%)
    module167 kB167 kB-75 B (-0.0%)

  • @firebase/auth/react-native

    TypeBase (4604b3c)Merge (f190613)Diff
    browser168 kB168 kB-98 B (-0.1%)
    module168 kB168 kB-98 B (-0.1%)

  • firebase

    TypeBase (4604b3c)Merge (f190613)Diff
    firebase-auth-compat.js126 kB126 kB-49 B (-0.0%)
    firebase-auth-cordova.js138 kB138 kB-84 B (-0.1%)
    firebase-auth-react-native.js150 kB150 kB-84 B (-0.1%)
    firebase-auth.js117 kB117 kB-50 B (-0.0%)
    firebase-compat.js746 kB746 kB-49 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/oiO6w6wwx6.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 24, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • multiFactor

      Size

      TypeBase (4604b3c)Merge (f190613)Diff
      size33.7 kB33.6 kB-75 B (-0.2%)
      size-with-ext-deps54.3 kB54.2 kB-75 B (-0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/I7VtC8t54N.html

sam-gc
sam-gc approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@sam-gc sam-gc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

@prameshj prameshj marked this pull request as ready for review January 24, 2023 18:54
@prameshj prameshj linked an issue Jan 24, 2023 that may be closed by this pull request
MFA bug on unenrolling last factor when you have more than one factor enrolled. #3233
Closed
@prameshj
Expose TOKEN_EXPIRED error upon mfa unenroll.
d943c2c 
This can be thrown if the MFA option that was most recently enrolled into, was unenrolled.
The user will be logged out to prove the posession of the other second factor.
This error can be handled by reauthenticating the user.

This change also updates the demo app to store the lastUser in case mfa unenroll logs out the user.
From here, the lastUser can be reauthenticated.
@prameshj
Changeset
6d22568
@prameshj prameshj merged commit 6439f11 into master Jan 24, 2023
@prameshj prameshj deleted the multiple-mfa-unenroll branch January 24, 2023 22:06
@prameshj prameshj mentioned this pull request Jan 25, 2023
Closed
@google-oss-bot google-oss-bot mentioned this pull request Jan 31, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam-gc sam-gc sam-gc approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

@avolkovi avolkovi Awaiting requested review from avolkovi

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@yuchenshi yuchenshi Awaiting requested review from yuchenshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MFA bug on unenrolling last factor when you have more than one factor enrolled.
3 participants
@prameshj @google-oss-bot @sam-gc