[Storage] Removed use of native Node 18 blobs #6705

maneesht · 2022-10-18T18:31:22Z

Removed use of native Node 18 blobs.

changeset-bot · 2022-10-18T18:31:25Z

🦋 Changeset detected

Latest commit: c876d7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/storage	Patch
firebase	Patch
@firebase/storage-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2022-10-18T18:52:14Z

Size Report ¹

Affected Products

@firebase/storage
Type Base (46596de) Merge (6bc5827) Diff
browser 55.6 kB 55.6 kB +18 B (+0.0%)
esm5 61.9 kB 61.9 kB +18 B (+0.0%)
main 58.5 kB 58.5 kB +16 B (+0.0%)
module 55.6 kB 55.6 kB +18 B (+0.0%)
bundle
Type Base (46596de) Merge (6bc5827) Diff
storage (uploadBytes) 46.4 kB 46.5 kB +123 B (+0.3%)
storage (uploadBytesResumable) 56.3 kB 56.5 kB +123 B (+0.2%)
storage (uploadString) 46.6 kB 46.7 kB +123 B (+0.3%)
firebase
Type Base (46596de) Merge (6bc5827) Diff
firebase-compat.js 740 kB 740 kB +6 B (+0.0%)
firebase-storage-compat.js 39.0 kB 39.1 kB +111 B (+0.3%)
firebase-storage.js 38.6 kB 38.7 kB +113 B (+0.3%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/4CAqp7UQpE.html

packages/storage/src/implementation/type.ts

google-oss-bot · 2022-10-18T19:09:34Z

Size Analysis Report ¹

Affected Products

@firebase/storage
- _FbsBlob
  Size
  Type Base (46596de) Merge (b33a355) Diff
  size 14.0 kB 14.1 kB +28 B (+0.2%)
  size-with-ext-deps 31.0 kB 31.1 kB +127 B (+0.4%)
  External Dependency
  Module Base (46596de) Merge (b33a355) Diff
  @firebase/util
  FirebaseError
  FirebaseError isNodeSdk
  + isNodeSdk
- _UploadTask
  Size
  Type Base (46596de) Merge (b33a355) Diff
  size 29.6 kB 29.6 kB +23 B (+0.1%)
  size-with-ext-deps 46.6 kB 46.7 kB +127 B (+0.3%)
  External Dependency
  Module Base (46596de) Merge (b33a355) Diff
  @firebase/util
  FirebaseError
  FirebaseError isNodeSdk
  + isNodeSdk
- uploadBytes
  Size
  Type Base (46596de) Merge (b33a355) Diff
  size 19.8 kB 19.8 kB +25 B (+0.1%)
  size-with-ext-deps 36.8 kB 36.9 kB +127 B (+0.3%)
  External Dependency
  Module Base (46596de) Merge (b33a355) Diff
  @firebase/util
  FirebaseError getModularInstance
  FirebaseError getModularInstance isNodeSdk
  + isNodeSdk
- uploadBytesResumable
  Size
  Type Base (46596de) Merge (b33a355) Diff
  size 29.8 kB 29.8 kB +23 B (+0.1%)
  size-with-ext-deps 46.8 kB 46.9 kB +127 B (+0.3%)
  External Dependency
  Module Base (46596de) Merge (b33a355) Diff
  @firebase/util
  FirebaseError getModularInstance
  FirebaseError getModularInstance isNodeSdk
  + isNodeSdk
- uploadString
  Size
  Type Base (46596de) Merge (b33a355) Diff
  size 20.0 kB 20.0 kB +25 B (+0.1%)
  size-with-ext-deps 37.0 kB 37.1 kB +127 B (+0.3%)
  External Dependency
  Module Base (46596de) Merge (b33a355) Diff
  @firebase/util
  FirebaseError getModularInstance
  FirebaseError getModularInstance isNodeSdk
  + isNodeSdk

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/G7afmJZUBN.html

google-oss-bot · 2022-10-18T19:09:35Z

Size Analysis Report ¹

Affected Products

@firebase/storage
- _FbsBlob
  Size
  Type Base (46596de) Merge (6bc5827) Diff
  size 14.0 kB 14.1 kB +25 B (+0.2%)
  size-with-ext-deps 31.0 kB 31.1 kB +123 B (+0.4%)
  External Dependency
  Module Base (46596de) Merge (6bc5827) Diff
  @firebase/util
  FirebaseError
  FirebaseError isNode
  + isNode
- _UploadTask
  Size
  Type Base (46596de) Merge (6bc5827) Diff
  size 29.6 kB 29.6 kB +20 B (+0.1%)
  size-with-ext-deps 46.6 kB 46.7 kB +123 B (+0.3%)
  External Dependency
  Module Base (46596de) Merge (6bc5827) Diff
  @firebase/util
  FirebaseError
  FirebaseError isNode
  + isNode
- uploadBytes
  Size
  Type Base (46596de) Merge (6bc5827) Diff
  size 19.8 kB 19.8 kB +22 B (+0.1%)
  size-with-ext-deps 36.8 kB 36.9 kB +123 B (+0.3%)
  External Dependency
  Module Base (46596de) Merge (6bc5827) Diff
  @firebase/util
  FirebaseError getModularInstance
  FirebaseError getModularInstance isNode
  + isNode
- uploadBytesResumable
  Size
  Type Base (46596de) Merge (6bc5827) Diff
  size 29.8 kB 29.8 kB +20 B (+0.1%)
  size-with-ext-deps 46.8 kB 46.9 kB +123 B (+0.3%)
  External Dependency
  Module Base (46596de) Merge (6bc5827) Diff
  @firebase/util
  FirebaseError getModularInstance
  FirebaseError getModularInstance isNode
  + isNode
- uploadString
  Size
  Type Base (46596de) Merge (6bc5827) Diff
  size 20.0 kB 20.0 kB +22 B (+0.1%)
  size-with-ext-deps 37.0 kB 37.1 kB +123 B (+0.3%)
  External Dependency
  Module Base (46596de) Merge (6bc5827) Diff
  @firebase/util
  FirebaseError getModularInstance
  FirebaseError getModularInstance isNode
  + isNode

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/G5H6LlMukN.html

…ebase/firebase-js-sdk into mtewani/disable-node18-blobs

packages/storage/src/implementation/type.ts

Added a comment

f1d512e

maneesht requested a review from tonyjhuang as a code owner October 18, 2022 18:31

maneesht changed the title ~~Added a comment~~ [Storage] Removed use of native Node 18 blobs Oct 18, 2022

Create chilled-forks-accept.md

ef4e236

maneesht requested a review from egilmorez as a code owner October 18, 2022 18:32

hsubox76 reviewed Oct 18, 2022

View reviewed changes

packages/storage/src/implementation/type.ts Outdated Show resolved Hide resolved

maneesht added 2 commits October 18, 2022 12:59

Replaced isNodeSdk with isNode

560b57e

Merge branch 'mtewani/disable-node18-blobs' of https://github.com/fir…

e15706f

…ebase/firebase-js-sdk into mtewani/disable-node18-blobs

hsubox76 approved these changes Oct 18, 2022

View reviewed changes

hsubox76 reviewed Oct 18, 2022

View reviewed changes

packages/storage/src/implementation/type.ts Outdated Show resolved Hide resolved

maneesht added 2 commits October 18, 2022 15:23

Fixed comment

1165e56

Further fixed comment

c876d7e

maneesht merged commit de1c717 into master Oct 19, 2022

maneesht deleted the mtewani/disable-node18-blobs branch October 19, 2022 02:18

google-oss-bot mentioned this pull request Oct 25, 2022

Version Packages #6727

Merged

firebase locked and limited conversation to collaborators Nov 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Storage] Removed use of native Node 18 blobs #6705

[Storage] Removed use of native Node 18 blobs #6705

maneesht commented Oct 18, 2022

changeset-bot bot commented Oct 18, 2022 •

edited

google-oss-bot commented Oct 18, 2022 •

edited

`@firebase/storage`

`bundle`

`firebase`

google-oss-bot commented Oct 18, 2022

`@firebase/storage`

`_FbsBlob`

`_UploadTask`

`uploadBytes`

`uploadBytesResumable`

`uploadString`

google-oss-bot commented Oct 18, 2022 •

edited

`@firebase/storage`

`_FbsBlob`

`_UploadTask`

`uploadBytes`

`uploadBytesResumable`

`uploadString`

[Storage] Removed use of native Node 18 blobs #6705

[Storage] Removed use of native Node 18 blobs #6705

Conversation

maneesht commented Oct 18, 2022

changeset-bot bot commented Oct 18, 2022 • edited

🦋 Changeset detected

google-oss-bot commented Oct 18, 2022 • edited

Size Report 1

Affected Products

@firebase/storage

bundle

firebase

Test Logs

google-oss-bot commented Oct 18, 2022

Size Analysis Report 1

Affected Products

@firebase/storage

_FbsBlob

_UploadTask

uploadBytes

uploadBytesResumable

uploadString

Test Logs

google-oss-bot commented Oct 18, 2022 • edited

Size Analysis Report 1

Affected Products

@firebase/storage

_FbsBlob

_UploadTask

uploadBytes

uploadBytesResumable

uploadString

Test Logs

changeset-bot bot commented Oct 18, 2022 •

edited

google-oss-bot commented Oct 18, 2022 •

edited

Size Report ¹

`@firebase/storage`

`bundle`

`firebase`

Size Analysis Report ¹

`@firebase/storage`

`_FbsBlob`

`_UploadTask`

`uploadBytes`

`uploadBytesResumable`

`uploadString`

google-oss-bot commented Oct 18, 2022 •

edited

Size Analysis Report ¹

`@firebase/storage`

`_FbsBlob`

`_UploadTask`

`uploadBytes`

`uploadBytesResumable`

`uploadString`