Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create FCM's CHANGELOG.md with a release note. #2837

Merged
merged 3 commits into from
Mar 31, 2020
Merged

Create FCM's CHANGELOG.md with a release note. #2837

merged 3 commits into from
Mar 31, 2020

Conversation

zwu52
Copy link
Member

@zwu52 zwu52 commented Mar 31, 2020 •
edited
Loading

FCM starts to have CHANGELOG.md for release notes (Thanks to the JS core and DevRel folks for creating/reviewing the previous release notes).

The first entry include the release note that is meant for the release scheduled on 2020-04-02.
The fix will address the issues in #2712

Create FCM's CHANGELOG.md with a release note.
91740ce 
This RN is meant for the release scheduled on 2020-04-02.
The fix will addresses the issues in #2712
egilmorez
egilmorez reviewed Mar 31, 2020
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Picked out a few things for you to look at.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 31, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

SDKTypeBase (50de3fb)Head (0bc3084)Diff
@firebase/firestore/memorybrowser224500.00224475.00-25.00 (-0.01%)
module221680.00221655.00-25.00 (-0.01%)
esm2017170334.00170304.00-30.00 (-0.02%)
main397701.00397404.00-297.00 (-0.07%)
@firebase/firestorebrowser271073.00271055.00-18.00 (-0.01%)
module267852.00267834.00-18.00 (-0.01%)
esm2017216152.00216141.00-11.00 (-0.01%)
main488427.00488418.00-9.00 (-0.00%)
firebasefirebase.js846912.00846872.00-40.00 (-0.00%)
firebase-firestore.memory.js266794.00266750.00-44.00 (-0.02%)
firebase-firestore.js312035.00311995.00-40.00 (-0.01%)
Metric Unit: byte

Test Logs

Update CHANGELOG.md
ba2d96b 
Improves wording on Eric's feedback. Thansk Eric
hsubox76
hsubox76 reviewed Mar 31, 2020
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one typo! Thanks for setting this up.

packages/messaging/CHANGELOG.md Outdated Show resolved Hide resolved
Update CHANGELOG.md
944edcc 
Fix a type
@zwu52 zwu52 merged commit aab78f9 into master Mar 31, 2020
@firebase firebase locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

@Feiyang1 Feiyang1 Awaiting requested review from Feiyang1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zwu52 @google-oss-bot @egilmorez @hsubox76