reliably update service worker #2638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 15, 2020
mmermerkaya
approved these changes
Feb 17, 2020
| @@ -167,6 +167,12 @@ export class WindowController implements FirebaseMessaging, FirebaseService { | |||
| scope: DEFAULT_SW_SCOPE | |||
| } | |||
| ); | |||
|
|
|||
| // The timing when browser updates sw when sw has an update is unreliable by my experiment. | |||
There was a problem hiding this comment.
by my experiment.
This bit won't really matter to a reader in the future 😄
hsubox76
approved these changes
Feb 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2590
It should fix any sw update issue going forward.