Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to SwiftFormat 0.49.2 #9239

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Update to SwiftFormat 0.49.2 #9239

merged 1 commit into from
Jan 21, 2022

Conversation

paulb777
Copy link
Member

#no-changelog

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseDatabase-iOS-FirebaseDatabase.framework

    Overall coverage changed from 56.89% (f2a396d) to 56.75% (054542e) by -0.14%.

    FilenameBase (f2a396d)Merge (054542e)Diff
    FSRWebSocket.m40.82%38.88%-1.95%

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 87.64% (f2a396d) to 87.69% (054542e) by +0.05%.

    FilenameBase (f2a396d)Merge (054542e)Diff
    exception.cc23.68%73.68%+50.00%
    exception_apple.mm89.66%58.62%-31.03%
    leveldb_key.cc97.68%97.37%-0.31%
    ordered_code.cc93.41%94.15%+0.73%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/reswZLFsoc.html

ryanwilson
ryanwilson approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, one thing we now need to be careful of is adding methods in a public extension could unintentionally publish a new API if we don't explicitly mark it as internal or private. Detection of API additions and changes will be very helpful.

@paulb777 paulb777 merged commit 5e8790d into master Jan 21, 2022
@paulb777 paulb777 deleted the pb-swiftformat-update branch January 21, 2022 21:03
@paulb777 paulb777 mentioned this pull request Jan 21, 2022
Merged
leotianlizhan pushed a commit that referenced this pull request Feb 1, 2022
@paulb777 @leotianlizhan
Update to SwiftFormat 0.49.2 (#9239)
7f3a5af
@firebase firebase locked and limited conversation to collaborators Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees
No one assigned
Labels
api: core api: database api: firestore api: inappmessaging Firebase In App Messaging api: remoteconfig api: storage release-tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulb777 @google-oss-bot @ryanwilson