Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require explicit typing for DocumentSnapshot decoding. DocumentReference decoding. #9101

Merged
merged 12 commits into from
Feb 23, 2022
Merged

Require explicit typing for DocumentSnapshot decoding. DocumentReference decoding. #9101

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0e4769c
Require explicit typing for DocumentSnapshot decoding. Add DocumentRe…
mortenbekditlevsen Dec 14, 2021
7815580
Updated doc comments. Added async version of getDocument(as:)
mortenbekditlevsen Dec 15, 2021
4ff41d7
Ran style.sh
mortenbekditlevsen Dec 15, 2021
37fb5be
Added LLC to copyright notice
mortenbekditlevsen Jan 3, 2022
6a94a62
Fixed up comments
mortenbekditlevsen Jan 18, 2022
31e3341
Merge branch 'master' into firestore_documentreference_codable
mortenbekditlevsen Jan 23, 2022
2eb244f
Ran style.sh
mortenbekditlevsen Jan 23, 2022
1d2f5d4
Change defaulting mechanism
mortenbekditlevsen Jan 27, 2022
c3e8cb3
Changes after review from Peter Friese
mortenbekditlevsen Feb 17, 2022
848f5e2
Updated CodableIntegrationTests to match updated API
mortenbekditlevsen Feb 18, 2022
f6a3733
Added offline behavior description from Objective-C documentation and…
mortenbekditlevsen Feb 22, 2022
9ce7b61
Updated comment after review
mortenbekditlevsen Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
Ran style.sh
  • Loading branch information
@mortenbekditlevsen
mortenbekditlevsen committed Jan 23, 2022
commit 2eb244f9d372357b8d0d14cbf9512dd1fb5d2308
20 changes: 10 additions & 10 deletions Firestore/Swift/Source/Codable/DocumentReference+ReadDecodable.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import Foundation
import FirebaseFirestore

extension DocumentReference {
public extension DocumentReference {
/// Fetches and decodes the document referenced by this `DocumentReference`.
///
/// This allows users to retrieve a Firestore document and have it decoded to an instance of
Expand All @@ -38,11 +38,11 @@ extension DocumentReference {
/// - decoder: The decoder to use to convert the document. `nil` to use
mortenbekditlevsen marked this conversation as resolved.
Show resolved Hide resolved
/// default decoder.
/// - completion: The closure to call when the document snapshot has been fetched and decoded.
public func getDocument<T: Decodable>(as type: T.Type,
with serverTimestampBehavior: ServerTimestampBehavior =
.none,
decoder: Firestore.Decoder? = nil,
completion: @escaping (Result<T, Error>) -> Void) {
func getDocument<T: Decodable>(as type: T.Type,
schmidt-sebastian marked this conversation as resolved.
Show resolved Hide resolved
with serverTimestampBehavior: ServerTimestampBehavior =
.none,
decoder: Firestore.Decoder? = nil,
completion: @escaping (Result<T, Error>) -> Void) {
getDocument { snapshot, error in
guard let snapshot = snapshot else {
completion(.failure(error ?? FirestoreDecodingError.internal))
mortenbekditlevsen marked this conversation as resolved.
Show resolved Hide resolved
Expand Down Expand Up @@ -77,10 +77,10 @@ extension DocumentReference {
/// default decoder.
/// - Returns: This instance of the supplied `Decodable` type `T`.
@available(iOS 15, tvOS 15, macOS 12, watchOS 8, *)
public func getDocument<T: Decodable>(as type: T.Type,
with serverTimestampBehavior: ServerTimestampBehavior =
.none,
decoder: Firestore.Decoder? = nil) async throws -> T {
func getDocument<T: Decodable>(as type: T.Type,
with serverTimestampBehavior: ServerTimestampBehavior =
.none,
decoder: Firestore.Decoder? = nil) async throws -> T {
let snapshot = try await getDocument()
return try snapshot.data(as: T.self,
with: serverTimestampBehavior,
Expand Down