Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not consider MutableDocument's state for DocumentSnapshot comparison #8647

Merged
merged 5 commits into from
Sep 21, 2021
Merged

Do not consider MutableDocument's state for DocumentSnapshot comparison #8647

merged 5 commits into from
Sep 21, 2021

Conversation

ehsannas
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in a feature request so that we
    can discuss it together.

@google-cla google-cla bot added the cla: yes label Sep 10, 2021
@google-oss-bot
Copy link

google-oss-bot commented Sep 10, 2021 •
edited

Binary Size Report

Affected SDKs

  • FirebaseFirestore

    Type Base (5a9ec53) Head (e048bd2) Diff
    firebase-ios-sdk ? 4.96 MB ? (?)

Test Logs

@google-oss-bot
Copy link

google-oss-bot commented Sep 10, 2021 •
edited

Coverage Report

Affected SDKs

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    SDK overall coverage changed from 88.54% (5a9ec53) to 88.47% (e048bd2) by -0.07%.

    Filename Base (5a9ec53) Head (e048bd2) Diff
    exception.cc 75.51% 24.49% -51.02%
    exception_apple.mm 58.62% 89.66% +31.03%
    leveldb_key.cc 97.96% 97.81% -0.15%

Test Logs

schmidt-sebastian
schmidt-sebastian reviewed Sep 17, 2021
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow review! Please ping me if you don't hear back within 24 hours (minus weekends - DO NOT PING ME ON WEEKENDS (*))

(*) at your own discretion.

Firestore/core/src/model/mutable_document.cc Outdated Show resolved Hide resolved
Firestore/core/src/api/document_snapshot.cc Outdated Show resolved Hide resolved
Firestore/core/src/model/mutable_document.cc Outdated Show resolved Hide resolved
@schmidt-sebastian
Copy link
Contributor

You should also add a changelog entry.

@ehsannas ehsannas removed their assignment Sep 20, 2021
@ehsannas ehsannas merged commit d191d0e into master Sep 21, 2021
@ehsannas ehsannas deleted the ehsann/fix-ds-equality branch September 21, 2021 20:06
@firebase firebase locked and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@ehsannas ehsannas

Labels
api: firestore cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ehsannas @google-oss-bot @schmidt-sebastian