Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage async await #8289

Merged
merged 18 commits into from
Jul 23, 2021
Merged

Storage async await #8289

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
11d52f7
Storage async await WIP
paulb777 Jun 22, 2021
6dbdd0f
Style and available
paulb777 Jun 22, 2021
cff5439
Fix build for Xcode 12.5
paulb777 Jun 25, 2021
fe4475c
style
paulb777 Jun 25, 2021
b5fea43
Use continuations
paulb777 Jun 25, 2021
7950d7e
style
paulb777 Jun 25, 2021
2ce439e
more tests
paulb777 Jun 27, 2021
fe66e51
more tests
paulb777 Jul 1, 2021
49775c0
Add writeAwait
paulb777 Jul 10, 2021
e863361
Resume with
paulb777 Jul 12, 2021
967e8ae
APIs with Async not Await
paulb777 Jul 13, 2021
8284cf5
typo
paulb777 Jul 13, 2021
33de2d7
Docs for new APIs
paulb777 Jul 14, 2021
7467a8c
style
paulb777 Jul 14, 2021
1d19bd1
Xcode 13 Beta 3 update
paulb777 Jul 15, 2021
25d0386
Only Task
paulb777 Jul 15, 2021
c47f35f
Update Changelog
paulb777 Jul 20, 2021
f8acfda
Address review feedback
paulb777 Jul 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
Style and available
  • Loading branch information
@paulb777
paulb777 committed Jul 23, 2021
commit 6dbdd0f6693607d40f62b2fb99148ee9f6848888
2 changes: 1 addition & 1 deletion FirebaseStorage/Sources/Public/FirebaseStorage/FIRStorageReference.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ NS_SWIFT_NAME(putData(_:metadata:));
metadata:(nullable FIRStorageMetadata *)metadata
completion:(nullable void (^)(FIRStorageMetadata *_Nullable metadata,
NSError *_Nullable error))completion
NS_SWIFT_NAME(putData(_:metadata:completion:));
NS_SWIFT_NAME(putData(_:metadata:completion:));

- (void)__putData:(NSData *)uploadData
metadata:(nullable FIRStorageMetadata *)metadata
Expand Down
8 changes: 4 additions & 4 deletions FirebaseStorageSwift/Sources/AsyncAwait.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@

import FirebaseStorage

@available(iOS 15.0, *)
public extension StorageReference {

@discardableResult
func putDataAwait(_ uploadData: Data,
metadata: StorageMetadata? = nil) async throws -> StorageMetadata {
// TODO: Add a parameter to capture StorageUploadTask and to enable Progress tracking.
metadata: StorageMetadata? = nil) async throws -> StorageMetadata {
// TODO: Add a parameter to capture StorageUploadTask and to enable Progress tracking.
// -> StorageUploadTask {
return try await __putDataGlue(uploadData, metadata: metadata)
return try await __putDataGlue(uploadData, metadata: metadata)
paulb777 marked this conversation as resolved.
Show resolved Hide resolved
}
}
2 changes: 1 addition & 1 deletion FirebaseStorageSwift/Tests/Integration/StorageAsyncAwait.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class StorageAsyncAwait: StorageIntegrationCommon {
let data = try XCTUnwrap("Hello Swift World".data(using: .utf8), "Data construction failed")
let result = try await ref.putDataAwait(data, metadata: nil)
XCTAssertNotNil(result)
let _ = try await ref.delete()
_ = try await ref.delete()
}

func testDeleteWithNilCompletion() throws {
Expand Down
1 change: 0 additions & 1 deletion FirebaseStorageSwift/Tests/Integration/StorageIntegration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import FirebaseStorageSwift
import XCTest

class StorageResultTests: StorageIntegrationCommon {

func testGetMetadata() {
let expectation = self.expectation(description: "testGetMetadata")
let ref = storage.reference().child("ios/public/1mb")
Expand Down
1 change: 1 addition & 0 deletions FirebaseStorageSwift/Tests/Integration/StorageIntegrationCommon.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ class StorageIntegrationCommon: XCTestCase {
}
waitForExpectations()
}

private func waitForExpectations() {
let kFIRStorageIntegrationTestTimeout = 60.0
paulb777 marked this conversation as resolved.
Show resolved Hide resolved
waitForExpectations(timeout: kFIRStorageIntegrationTestTimeout,
Expand Down