Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test case for firebase/firebase-functions#926 #116

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Failing test case for firebase/firebase-functions#926 #116

wants to merge 1 commit into from

Conversation

rhodgkins
Copy link
Contributor

Description

See firebase/firebase-functions#926

Will be fixed once that is merged in and the firebase-function dependency updated.

Code sample

See test case

  it('should allow null child value in makeDataSnapshot', async () => {
    const snapshot = makeDataSnapshot({ foo: null }, 'path');

    expect(snapshot.exists()).be.false;
    expect(snapshot.val()).to.deep.equal(null);
    expect(snapshot.ref.key).to.equal('path');
  });

@rhodgkins
Copy link
Contributor Author

Frustratingly the required changes to fix this have been pushed back to v4 of firebase-functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rhodgkins