Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IngressSettings support #827

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Conversation

takaaa220
Copy link
Contributor

@takaaa220 takaaa220 commented Dec 12, 2020

#815 PR has been merged and released to support IngressSettings.
However, as I commented on #808 (comment), it doesn't seem to work properly, so I fixed it.

My related PR in firebase-tools is firebase/firebase-tools#2924

Thanks!

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Dec 12, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@takaaa220
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Dec 12, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@takaaa220 takaaa220 changed the title Fix IngressSettings Fix IngressSettings support Dec 12, 2020
@samtstern
Copy link
Contributor

Thanks for this contribution! @joehan can you take a look at this PR as well as firebase/firebase-tools#2924 ?

@joehan joehan merged commit 5f64797 into firebase:master Jan 19, 2021
joehan added a commit that referenced this pull request Jan 19, 2021
samtstern pushed a commit that referenced this pull request Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants