Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change LogDebug to NSLog in app's swizzling code. #783

Merged
merged 5 commits into from
Dec 2, 2021
Merged

Change LogDebug to NSLog in app's swizzling code. #783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fdf9770
Change LogDebug to NSLog.
jonsimantov Dec 2, 2021
97be383
Change log message.
jonsimantov Dec 2, 2021
426f4c7
Remove extra line.
jonsimantov Dec 2, 2021
47b66ee
Add comment.
jonsimantov Dec 2, 2021
bbaec6b
Add release note for fix.
jonsimantov Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/invites/ios/invites_ios_startup.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,8 @@ static void HookAppDelegateMethods(Class clazz) {
// http://www.opensource.apple.com/source/objc4/objc4-274/runtime/objc-runtime.m)
@implementation UIApplication (FIRFBI)
+ (void)load {
::firebase::LogDebug("Loading UIApplication FIRFBI category");
// C++ constructors may not be called yet so call NSLog rather than LogDebug.
NSLog(@"Loading UIApplication category for Firebase App");
::firebase::util::ForEachAppDelegateClass(^(Class clazz) {
::firebase::invites::HookAppDelegateMethods(clazz);
});
Expand Down
7 changes: 7 additions & 0 deletions release_build_files/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,6 +567,13 @@ workflow use only during the development of your app, not for publicly shipping
code.

## Release Notes
### Next Release
- Changes
- General (iOS): Fixed an intermittent crash on iOS 15 caused by
constructing C++ objects during Objective-C's `+load` method.
([#706](https://github.com/firebase/firebase-cpp-sdk/pull/706))
([#783](https://github.com/firebase/firebase-cpp-sdk/pull/783))

### 8.8.0
- Changes
- General: Fixed a data race that could manifest as null pointer
Expand Down