Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link in readme #768

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Fix link in readme #768

merged 1 commit into from
Nov 30, 2021

Conversation

borissoft
Copy link
Contributor

Description

Fixed link in README.md file.


Testing

No need for testing.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@google-cla google-cla bot added the cla: yes label Nov 30, 2021
@jonsimantov jonsimantov self-requested a review November 30, 2021 18:56
@jonsimantov jonsimantov merged commit fdd1975 into firebase:main Nov 30, 2021
jonsimantov added a commit that referenced this pull request Dec 4, 2021
* Fix link in readme (#768)

* update test devices (#757)

* Timeout and Retry FTL failures and mark flakiness

* Update C++ SDK version to 8.8.0.

* Add Analytics header update to iOS SDK update. (#775)

* Add Analytics header update to iOS SDK update.

* Update Android dependencies - Wed Dec 01 2021 (#773)

### Android

- com.google.firebase.firebase_database → 20.0.3
- com.google.firebase.firebase_perf → 20.0.4

> Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/1527401903).

Co-authored-by: firebase-workflow-trigger-bot <[email protected]>

* Fix typo in log output.

* Change Xcode version from 12.2 to 12.4 to ensure GitHub support. (#774)

* Change Xcode version from 12.2 to 12.4 to ensure GitHub support.

* Fix integration tests workflow to respect xcode_version in matrix.

* Add extra newline to header comment.

* Update iOS dependencies - Thu Dec 02 2021 (#779)

* Update iOS dependencies - Thu Dec 02 2021

### iOS

- Firebase/Analytics → 8.10.0
- Firebase/Auth → 8.10.0
- Firebase/Core → 8.10.0
- Firebase/Crashlytics → 8.10.0
- Firebase/Database → 8.10.0
- Firebase/DynamicLinks → 8.10.0
- Firebase/Firestore → 8.10.0
- Firebase/Functions → 8.10.0
- Firebase/Installations → 8.10.0
- Firebase/Messaging → 8.10.0
- Firebase/RemoteConfig → 8.10.0
- Firebase/Storage → 8.10.0

> Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/1528664697).

* Add missing copyright lines.

* Add Firestore release note.

Co-authored-by: firebase-workflow-trigger-bot <[email protected]>
Co-authored-by: Jon Simantov <[email protected]>

* Properly convert milliseconds to seconds (#767)

* Properly convert milliseconds to seconds

Currently, a value expressed in milliseconds is directly assigned to a variable
which is supposed to store seconds and it's later converted to mills again.
Thus, convert properly upon assignment

* Update readme.md

* Change LogDebug to NSLog in app's swizzling code. (#783)

* Change LogDebug to NSLog.

* Change log message.

* Add comment.

* Add copyright line when importing Analytics iOS headers, if missing (#780)

* Add copyright line to iOS headers

* Make copyright conditional to whether the file already has one.

* Also set Xcode version explicitly in Android workflow. (#786)

* Timeout & retry "install integration test deps" step (#785)

* Format code.

Co-authored-by: Борис Рязанцев <[email protected]>
Co-authored-by: Mou Sun <[email protected]>
Co-authored-by: firebase-workflow-trigger[bot] <80733318+firebase-workflow-trigger[bot]@users.noreply.github.com>
Co-authored-by: firebase-workflow-trigger-bot <[email protected]>
Co-authored-by: pawelsnk <[email protected]>
@firebase firebase locked and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants