Messaging crash during initialization #760
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the unity quick start forum there is a bug report about messaging also crashing during startup. firebase/firebase-unity-sdk#73 . I have not been able to reproduce this but as it looked a lot like the shutdown crashes I thought I would have a quick look.
During the initialisation() function it calls SetTokenRegistrationOnInitEnabled() which in turn trickles down to a GetToken() call and if the Task is quick enough (i.e if we don't have an internet connection maybe?) it will trigger the CompleteStringCallback before FutureData::Create has been called.
Creating the FutureData before calling SetTokenRegistrationOnInitEnabled() is a "potential" fix as I have not seen the actual crash myself.
Testing
Type of Change
Place an
x
the applicable box:Notes
Release Notes
section ofrelease_build_files/readme.md
.