Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the way to achieve token while init the app #667

Merged
merged 8 commits into from
Sep 17, 2021
Merged

Change the way to achieve token while init the app #667

merged 8 commits into from
Sep 17, 2021

Conversation

cynthiajoan
Copy link
Contributor

@cynthiajoan cynthiajoan commented Sep 17, 2021 •
edited

The current way to grab token is starting a new IntentService, and tried to get IID token. Since we already have the new API to get installations token with a Future function call, it's better to use the new way and deprecate the IID related code.

This fix will address the issue firebase/quickstart-unity#1088

@google-cla google-cla bot added the cla: yes label Sep 17, 2021
@cynthiajoan cynthiajoan added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Sep 17, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Sep 17, 2021
@github-actions
Copy link

github-actions bot commented Sep 17, 2021 •
edited

✅  Integration test succeeded!

Requested by @cynthiajoan on commit 520af2c
Last updated: Fri Sep 17 13:36 PDT 2021
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Sep 17, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 17, 2021
DellaBitta
DellaBitta reviewed Sep 17, 2021
View reviewed changes
release_build_files/readme.md
@@ -567,10 +567,16 @@ code.

## Release Notes

### Future Release
- Changes
- Messaging (Android): Fixes an issue to receive token when
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed instad of Fixes

@cynthiajoan cynthiajoan merged commit 520af2c into main Sep 17, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Sep 17, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 17, 2021
jonsimantov
jonsimantov reviewed Sep 20, 2021
View reviewed changes
release_build_files/readme.md
@@ -567,10 +567,16 @@ code.

## Release Notes

### Future Release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to the actual version number of the upcoming release at the next opportunity, per http://go/firebase-cpp-release.

@firebase firebase locked and limited conversation to collaborators Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonsimantov jonsimantov jonsimantov left review comments

@DellaBitta DellaBitta DellaBitta approved these changes

Assignees
No one assigned
Labels
cla: yes tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cynthiajoan @jonsimantov @DellaBitta