Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OR Query Implementation #1453

Merged
merged 30 commits into from
Sep 22, 2023
Merged

OR Query Implementation #1453

merged 30 commits into from
Sep 22, 2023

Conversation

tom-andersen
Copy link
Contributor

Fixed #1335 with new version of Android Firebase SDK.

# Conflicts:
#	release_build_files/readme.md
@tom-andersen tom-andersen merged commit f81dfe1 into main Sep 22, 2023
30 checks passed
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Sep 22, 2023
@github-actions
Copy link

github-actions bot commented Sep 22, 2023

❌  Integration test FAILED

Requested by @tom-andersen on commit f81dfe1
Last updated: Fri Sep 22 08:51 PDT 2023
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [Windows] [x64] [openssl]
app_check [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT
[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
firestore [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  FirestoreTest.AuthWorks
storage [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Sep 22, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 22, 2023
jonsimantov added a commit that referenced this pull request Oct 2, 2023
* iOS: Remove Analytics dependency from GMA integration test (#1386)

* Try using CoreOnly instead of Analytics cocoapod for tests.

* Update readme.

* Add stub workflow for updating feature branches.

* Add script to merge main into all active feature branches on a regular schedule. (#1394)

* Add workflow for automatically updating feature branches weekly.

* Corrected filename, and added inputs.

* Remove trailing spaces.

* Fix workflow.

* Fix workflow name.

* Fix syntax.

* Fix syntax.

* List remote branches instead.

* Clean up script.

* Untab.

* Add branch list for debugging.

* Untab.

* Specify remote branches.

* Skip second stage if no first.

* Typo

* Error.

* List all branches.

* Fix logic.

* Fix spacing.

* Fix output

* Fix parameters.

* Fix merge to use origin.

* Remove debug echos.

* Add git config.

* Fix PR creation.

* Fix PR creation.

* Fix automatic push.

* Increase retry. (#1402)

* Add Firestore test history report (#1403)

* Add --firestore flag to report Firestore history.

* Add Firestore report to nightly cron job.

* Remove multiline commands.

* Revert "Remove multiline commands."

This reverts commit 6393ae9.

* Fix tabbing.

* Fix packaging test detection for Firestore.

* Revert "OR Query Implementation (#1335)" (#1399)

This reverts commit 11332d4.

* Wrap the real-time RemoteConfig test in flaky-block to automatically retry. (#1406)

* Only use flaky_test on android

* Update the iOS version used by FTL (#1408)

* Kick off nightly packaging an hour earlier (#1409)

* Fix crash on gma::Initialize without a Firebase App (#1320)

Initialize Util before using Util::FIndClass. Also add an integration test for initializing gma without a firebase app.

* build: pass along the CMake path (#1410)

When building the subproject, we would invoke `cmake` directly, relying on the path lookup of the tool, which may or may not match the currently executing CMake.  Use `CMAKE_COMMAND` which gives us the path to the current CMake executable ensuring that we use the same CMake for building the dependencies.

* Add log to gsutil fetch. (#1411)

* Update mobile dependencies - Thu Aug 03 2023 (#1413)

* Update mobile dependencies - Thu Aug 03 2023

### Android

- com.google.firebase.firebase_bom → 32.2.2

### iOS

- Firebase/Analytics → 10.13.0
- Firebase/AppCheck → 10.13.0
- Firebase/Auth → 10.13.0
- Firebase/Core → 10.13.0
- Firebase/CoreOnly → 10.13.0
- Firebase/Crashlytics → 10.13.0
- Firebase/Database → 10.13.0
- Firebase/DynamicLinks → 10.13.0
- Firebase/Firestore → 10.13.0
- Firebase/Functions → 10.13.0
- Firebase/Installations → 10.13.0
- Firebase/Messaging → 10.13.0
- Firebase/RemoteConfig → 10.13.0
- Firebase/Storage → 10.13.0
- Google-Mobile-Ads-SDK → 10.9.0

> Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/5755777170).

* Ensure using a Swift bridging header that supports both arm64 and x86_64.

* Add release note about i386 no longer being supported.

* Remove armv7 as well.

---------

Co-authored-by: firebase-workflow-trigger-bot <[email protected]>
Co-authored-by: Jon Simantov <[email protected]>
Co-authored-by: [email protected] <[email protected]>

* feat(auth): Add emulator support (#1400)

* add auth emulator support

* fix ios number parse

* update the documentation part

* reduce lint warning

* more lint warnings

* code format

* use environment to decide using emulator or not

* fix a typo

* add readme entry for FirebaseApp.GetApps()

* update for review comment

* add missing `

---------

Co-authored-by: Cynthia Jiang <[email protected]>

* Update merge-to-main script (#1420)

* Before creating the merge-main PR, branch it off main, so merge conflicts can be addressed in the branch rather than by committing to main.

* Format.

* Update release version number for M135, 11.4.0 (#1421)

* feat(auth): enable emulator support on desktop (#1423)

* add auth emulator support

* fix ios number parse

* update the documentation part

* reduce lint warning

* more lint warnings

* code format

* use environment to decide using emulator or not

* fix a typo

* add readme entry for FirebaseApp.GetApps()

* update for review comment

* add missing `

* make json request always do restrict json

* add readme info

* prepare for review

* some minor tweak

* code format

* update review comments

* update the unit test after request json change

---------

Co-authored-by: Cynthia Jiang <[email protected]>

* Internal Updates. (#1422)

* Add logic to trim webp parameter from native image urls

* Add Analytics function for on-device conversion (#1429)

* Add Analytics function for phone number conversion

* Formatting

* Update analytics.h

* Update analytics_test.cc

* Update mobile dependencies - Tue Aug 29 2023 (#1436)

* Update mobile dependencies - Tue Aug 29 2023

### Android

- com.google.android.gms.play_services_ads → 22.3.0
- com.google.firebase.firebase_bom → 32.2.3

### iOS

- Firebase/Analytics → 10.14.0
- Firebase/AppCheck → 10.14.0
- Firebase/Auth → 10.14.0
- Firebase/Core → 10.14.0
- Firebase/CoreOnly → 10.14.0
- Firebase/Crashlytics → 10.14.0
- Firebase/Database → 10.14.0
- Firebase/DynamicLinks → 10.14.0
- Firebase/Firestore → 10.14.0
- Firebase/Functions → 10.14.0
- Firebase/Installations → 10.14.0
- Firebase/Messaging → 10.14.0
- Firebase/RemoteConfig → 10.14.0
- Firebase/Storage → 10.14.0

> Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/6016988287).

* Update query_main to use normalized_order_bys

* Update query_main.cc

---------

Co-authored-by: firebase-workflow-trigger-bot <[email protected]>
Co-authored-by: a-maurice <[email protected]>

* add UseEmulator api to auth (#1437)

* add auth emulator support

* fix ios number parse

* update the documentation part

* reduce lint warning

* more lint warnings

* code format

* use environment to decide using emulator or not

* fix a typo

* add readme entry for FirebaseApp.GetApps()

* update for review comment

* add missing `

* make json request always do restrict json

* add readme info

* prepare for review

* some minor tweak

* code format

* update review comments

* update the unit test after request json change

* remove platform logging v1 code

* add useEmulator api

* test with emulator

* clean up for review

* tweak for review

* update with comments

* put back necessary heartbeat blocks

---------

Co-authored-by: Cynthia Jiang <[email protected]>

* On Android, set dynamic code files to readonly (#1430)

* To address an Android 14 security issue, set dex files to readonly.

This follows the advice on dynamic code loading here:
https://developer.android.com/about/versions/14/behavior-changes-14#safer-dynamic-code-loading

* Format code.

* Reorder exception check so that we cover all the spots.

* Add release note.

* Update iOS dependencies - Tue Sep 12 2023 (#1443)

### iOS

- Firebase/Analytics → 10.15.0
- Firebase/AppCheck → 10.15.0
- Firebase/Auth → 10.15.0
- Firebase/Core → 10.15.0
- Firebase/CoreOnly → 10.15.0
- Firebase/Crashlytics → 10.15.0
- Firebase/Database → 10.15.0
- Firebase/DynamicLinks → 10.15.0
- Firebase/Firestore → 10.15.0
- Firebase/Functions → 10.15.0
- Firebase/Installations → 10.15.0
- Firebase/Messaging → 10.15.0
- Firebase/RemoteConfig → 10.15.0
- Firebase/Storage → 10.15.0
- Google-Mobile-Ads-SDK → 10.10.0

> Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/6164028143).

Co-authored-by: firebase-workflow-trigger-bot <[email protected]>

* Apply unused variables patch to Flatbuffers on Android as well. (#1444)

Already applied on desktop elsewhere.

* Fix iOS test version from deprecate 16.5 to 16.6. (#1449)

* Update Android dependencies - Mon Sep 18 2023 (#1448)

* Update release version to 11.5.0.

* Update readme.

* Update Android dependencies - Mon Sep 18 2023

### Android

- com.google.android.gms.play_services_ads → 22.4.0
- com.google.firebase.firebase_bom → 32.3.1

> Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/6226059256).

* Add note about GMA Android.

* Revert play-services-ads to 22.3.0.

---------

Co-authored-by: Jon Simantov <[email protected]>
Co-authored-by: firebase-workflow-trigger-bot <[email protected]>

* Add a matrix label to FTL test runs, to make sorting them easier. (#1452)

* Add a matrix label to FTL test runs, to make sorting them easier.

* Fix label for iOS

* OR Query Implementation (#1453)

* OR Query Implementation

* Pretty

* Add includes

* Fix from PR feedback

* Fix variadic parameters

* Add and fix tests

* Add/fix method descriptions.

* Add/fix constructor and class descriptions.

* Add method description to disjunction/conjunction.

* Add tests. Revealed bugs to be fixed.

* Fix type

* Add test

* Android implementation

* Pretty

* Pretty

* Pretty

* Remove const

* Pretty

* Fixes from code review

* Release notes

* Release notes

* Fix Android OR Query

* Release notes.

* Fix release notes.

* Format

* Internal Updates (#1439)

* Internal Updates

* Revert firestore to main.

* Add additional release note.

* Fix bad merge output.

---------

Co-authored-by: Tom Andersen <[email protected]>
Co-authored-by: Matthew Hyndman <[email protected]>
Co-authored-by: a-maurice <[email protected]>
Co-authored-by: Saleem Abdulrasool <[email protected]>
Co-authored-by: firebase-workflow-trigger[bot] <80733318+firebase-workflow-trigger[bot]@users.noreply.github.com>
Co-authored-by: firebase-workflow-trigger-bot <[email protected]>
Co-authored-by: Cynthia J <[email protected]>
Co-authored-by: Cynthia Jiang <[email protected]>
Co-authored-by: nakirekommula <[email protected]>
@firebase firebase locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants