Fix set user id for on-demand fatal #5275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Generated by 🚫 Danger |
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
themiswang
commented
Aug 23, 2023
...roidTest/java/com/google/firebase/crashlytics/internal/common/CrashlyticsControllerTest.java
Show resolved
Hide resolved
themiswang
commented
Aug 23, 2023
...rc/androidTest/java/com/google/firebase/crashlytics/internal/metadata/MetaDataStoreTest.java
Show resolved
Hide resolved
themiswang
commented
Aug 23, 2023
...ics/src/main/java/com/google/firebase/crashlytics/internal/common/CrashlyticsController.java
Show resolved
Hide resolved
themiswang
commented
Aug 28, 2023
...rashlytics/src/main/java/com/google/firebase/crashlytics/internal/metadata/UserMetadata.java
Show resolved
Hide resolved
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Startup time comparison between the CI merge commit (8b89c18) and the base commit (dff55b6) are not available. No macrobenchmark data found for the base commit (dff55b6). Analysis for the CI merge commit (8b89c18) can be found at: |
themiswang
added a commit
that referenced
this pull request
Sep 1, 2023
For on-demand fatal, we will need to close the previous session and open a new session during app life cycle. We need to port over the previous UserMetadata state (including user id, custom keys etc) for the new session. Decide to merge to master later as a part of feature rollouts project. Original PR: #5275
themiswang
added a commit
that referenced
this pull request
Sep 5, 2023
For on-demand fatal, we will need to close the previous session and open a new session during app life cycle. We need to port over the previous UserMetadata state (including user id, custom keys etc) for the new session. Decide to merge to master later as a part of feature rollouts project. Original PR: #5275
|
Close this PR since we have decide the fix will be a part of feature release. fix merged #5292 |
themiswang
added a commit
that referenced
this pull request
Sep 25, 2023
For on-demand fatal, we will need to close the previous session and open a new session during app life cycle. We need to port over the previous UserMetadata state (including user id, custom keys etc) for the new session. Decide to merge to master later as a part of feature rollouts project. Original PR: #5275
themiswang
added a commit
that referenced
this pull request
Oct 3, 2023
For on-demand fatal, we will need to close the previous session and open a new session during app life cycle. We need to port over the previous UserMetadata state (including user id, custom keys etc) for the new session. Decide to merge to master later as a part of feature rollouts project. Original PR: #5275
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For on-demand fatal, we will need to close the previous session and open a new session during app life cycle. We need to port over the previous UserMetadata state (including user id, custom keys etc) for the new session.
Related issue: firebase/flutterfire#10759