Remove use of method_whitelist when possible #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
hiranya911
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
Thanks for the PR @xmo-odoo. This looks great! I just made a couple of comments. We can merge this once those comments are addressed.
Done and done, though now that I look at the code again I'm wondering: maybe I should remove the current That is, end up with this: if hasattr(retry.Retry.DEFAULT, 'allowed_methods'):
_ANY_METHOD = {'allowed_methods': None}
else:
_ANY_METHOD = {'method_whitelist': None}
# Default retry configuration: Retries once on low-level connection and socket read errors.
# Retries up to 4 times on HTTP 500 and 503 errors, with exponential backoff. Returns the
# last response upon exhausting all retries.
DEFAULT_RETRY_CONFIG = retry.Retry(
connect=1, read=1, status=4, status_forcelist=[500, 503],
raise_on_status=False, backoff_factor=0.5, **_ANY_METHOD) |
|
Thanks @xmo-odoo. Your suggestion looks good to me. Feel free to make the change. But I'm happy with the current state of the PR too. |
Deprecated in favor of allowed_methods. Fall back to the old argument for older versions of urllib3 which do not support the new one. Uses conditional attribute check as recommended in urllib3/urllib3#2057
|
@hiranya911 I pushed the updated version. |
hiranya911
approved these changes
Feb 10, 2021
sts-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Sep 28, 2022
With version of urllib3 in ubuntu 22.04 (1.26.5) and with version of firebase_admin between 2.17.0 and 4.5.2 a gives the following warning: In firebase_admin/_http_client.py:30: DeprecationWarning: Using 'method_whitelist' with Retry is deprecated and will be removed in v2.0. Use 'allowed_methods' instead It has been fixed in later version firebase/firebase-admin-python#532 since v4.5.2
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Sep 30, 2022
With version of urllib3 in ubuntu 22.04 (1.26.5) and with version of firebase_admin between 2.17.0 and 4.5.2 a gives the following warning: In firebase_admin/_http_client.py:30: DeprecationWarning: Using 'method_whitelist' with Retry is deprecated and will be removed in v2.0. Use 'allowed_methods' instead It has been fixed in later version firebase/firebase-admin-python#532 since v4.5.2 closes #101444 Signed-off-by: Christophe Monniez (moc) <[email protected]>
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Sep 30, 2022
With version of urllib3 in ubuntu 22.04 (1.26.5) and with version of firebase_admin between 2.17.0 and 4.5.2 a gives the following warning: In firebase_admin/_http_client.py:30: DeprecationWarning: Using 'method_whitelist' with Retry is deprecated and will be removed in v2.0. Use 'allowed_methods' instead It has been fixed in later version firebase/firebase-admin-python#532 since v4.5.2 closes #101444 Signed-off-by: Christophe Monniez (moc) <[email protected]>
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Sep 30, 2022
With version of urllib3 in ubuntu 22.04 (1.26.5) and with version of firebase_admin between 2.17.0 and 4.5.2 a gives the following warning: In firebase_admin/_http_client.py:30: DeprecationWarning: Using 'method_whitelist' with Retry is deprecated and will be removed in v2.0. Use 'allowed_methods' instead It has been fixed in later version firebase/firebase-admin-python#532 since v4.5.2 X-original-commit: 66934cd
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Oct 6, 2022
With version of urllib3 in ubuntu 22.04 (1.26.5) and with version of firebase_admin between 2.17.0 and 4.5.2 a gives the following warning: In firebase_admin/_http_client.py:30: DeprecationWarning: Using 'method_whitelist' with Retry is deprecated and will be removed in v2.0. Use 'allowed_methods' instead It has been fixed in later version firebase/firebase-admin-python#532 since v4.5.2 closes #101731 X-original-commit: 66934cd Signed-off-by: Christophe Monniez (moc) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated in favor of allowed_methods. Fall back to the old argument for older
versions of urllib3 which do not support the new one.
Uses conditional attribute check as recommended in
urllib3/urllib3#2057
Fixes #515
RELEASE NOTE: Fixed a bug that prevented the proper operation of the SDK when used with certain versions of the
urllib3package.