Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fcm): Fix Unmarshal typo, add tests to verify #435

Merged
merged 1 commit into from
Apr 29, 2021
Merged

fix(fcm): Fix Unmarshal typo, add tests to verify #435

merged 1 commit into from
Apr 29, 2021

Conversation

parnic
Copy link
Contributor

@parnic parnic commented Apr 29, 2021

Fixes #434

hiranya911
hiranya911 approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hiranya911 hiranya911 changed the title Fix Unmarshal typo, add tests to verify fix(fcm): Fix Unmarshal typo, add tests to verify Apr 29, 2021
@hiranya911 hiranya911 merged commit 18f3a65 into firebase:dev Apr 29, 2021
@parnic parnic deleted the dev branch April 29, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

Assignees
No one assigned
Labels
release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@parnic @hiranya911