Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding golang 1.13 to the CI matrix #294

Merged
merged 4 commits into from
Nov 6, 2019
Merged

feat: Adding golang 1.13 to the CI matrix #294

merged 4 commits into from
Nov 6, 2019

Conversation

shogo82148
Copy link
Contributor

@shogo82148 shogo82148 commented Nov 5, 2019 •
edited by hiranya911

Latest Go release is v1.13

RELEASE NOTE: Dropped support for Go 1.9 and 1.10. Go Admin SDK now requires Go 1.11 or higher.

hiranya911
hiranya911 suggested changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Let's align with the Google Cloud Go clients, and bump our minimum requirement to go 1.11.

Also change the base branch to dev.

.travis.yml Outdated Show resolved Hide resolved
README.md Outdated
@@ -43,7 +43,7 @@ requests, code review feedback, and also pull requests.

We support Go v1.9 and higher.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change to 1.11.

@shogo82148 shogo82148 changed the base branch from master to dev November 5, 2019 23:51
@shogo82148
Copy link
Contributor Author

Thank you for your review. I fixed it.
Please review it again!

hiranya911
hiranya911 approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hiranya911 hiranya911 changed the title Adding golang 1.13 to the CI matrix feat: Adding golang 1.13 to the CI matrix Nov 6, 2019
@hiranya911 hiranya911 self-assigned this Nov 6, 2019
@hiranya911 hiranya911 merged commit 874c9df into firebase:dev Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

Assignees

@hiranya911 hiranya911

Labels
release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shogo82148 @hiranya911