Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing an error formatting bug in FCM tests #225

Merged
merged 2 commits into from
Feb 26, 2019
Merged

Fixing an error formatting bug in FCM tests #225

merged 2 commits into from
Feb 26, 2019

Conversation

hiranya911
Copy link
Contributor

New Go tools are pedantic about this:

# firebase.google.com/go/messaging
../../go-workspace/src/firebase.google.com/go/messaging/messaging_test.go:1091:5: Errorf format %q has arg name of wrong type *firebase.google.com/go/messaging.TopicManagementResponse
../../go-workspace/src/firebase.google.com/go/messaging/messaging_test.go:1133:5: Errorf format %q has arg name of wrong type *firebase.google.com/go/messaging.TopicManagementResponse
../../go-workspace/src/firebase.google.com/go/messaging/messaging_test.go:1185:4: Errorf format %q has arg tmr of wrong type *firebase.google.com/go/messaging.TopicManagementResponse
../../go-workspace/src/firebase.google.com/go/messaging/messaging_test.go:1192:4: Errorf format %q has arg tmr of wrong type *firebase.google.com/go/messaging.TopicManagementResponse

@hiranya911 hiranya911 assigned hiranya911 and unassigned bklimt Feb 26, 2019
@hiranya911 hiranya911 merged commit 494dfce into dev Feb 26, 2019
@hiranya911 hiranya911 deleted the hkj-test-fix branch February 26, 2019 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bklimt bklimt bklimt approved these changes

Assignees

@hiranya911 hiranya911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hiranya911 @bklimt