Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add channel_id in messaging.AndroidNotification #202

Merged
merged 3 commits into from
Nov 30, 2018
Merged

add channel_id in messaging.AndroidNotification #202

merged 3 commits into from
Nov 30, 2018

Conversation

chemidy
Copy link
Contributor

@chemidy chemidy commented Nov 30, 2018

AndroidNotification now supports channel_id

@chemidy chemidy changed the title Channel add channel_id in messaging.AndroidNotification Nov 30, 2018
hiranya911
hiranya911 approved these changes Nov 30, 2018
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiranya911 hiranya911 self-assigned this Nov 30, 2018
@hiranya911 hiranya911 merged commit 56926c1 into firebase:dev Nov 30, 2018
@hiranya911 hiranya911 mentioned this pull request Nov 30, 2018
Closed
@chemidy chemidy deleted the channel-id branch December 1, 2018 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

Assignees

@hiranya911 hiranya911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chemidy @hiranya911