We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Have done another CLA - Forgot my git config email address is different to my github email address.

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Thanks for the review @hiranya911 a lot of good suggestions, I'm grateful for that and have implemented those. Let me know what you think about the new changes?

I also wanted to ask - I've not yet built and run this against a real application (IE: Subscribing my personal phone to a topic using this code, then sending a message to the topic and receiving it) - Is that something I should do, or maintainers do, or is there another practice commonly followed?

Hi @hiranya911 , I've made the changes you suggested, thanks again for your feedback.

Making the InstanceIdServiceResponse class a private class of InstanceIdClient means I can't provide it to the constructor of TopicManagementResponse (Unless I've missed a trick here?) so I have passed a list of all the messages from the InstanceIdServiceResponse instead. Let me know if you think there is a better approach. I had wanted to convert the InstanceIdServiceResponse to a List of ErrorInfo inside the InstanceIdClient and pass that to TopicManagementResponse constructor - but then although I can provide the index of the error back to the library caller, I can't provide the success count without adding another parameter, which seems a little "off" - It may be a cleaner approach though - Let me know what you think.

I've added in HTTP status code error tests as requested, they all throw FirebaseMessagingException which looks to come from the FirebaseAdmin.Messaging.HttpErrorHandler so should give something useful to the caller.

Looking forward to the feedback again, let me know what you think :)

Thanks again for all you time, help, and patience here @hiranya911

I have a couple of questions if that's OK?

What sort of time does it usually take for this to end up in the nuget package?

Once this goes in, can I call myself a "Google code contributor" or "Google contributor" or is there another term for people who add to this project :)

Thanks again for the pull request @Leo-Mepham. I'll try to get this included in this week's release. If not definitely next week.

I don't think we have an official term for the developers who contribute to our open source projects :) @samtstern do you have any thoughts on that?

In any case, please note that we are really grateful for your contribution, and we will make a note of that in the release notes when this goes out. I look forward to receiving more contributions from you in the future :)

@Leo-Mepham I'm told it's ok to refer to developers like you as "Google contributors". But please be sure to not represent yourself as a Google employee :)

Great stuff, thanks @hiranya911 👍