Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current behavior of "What caused this update?" to point to host root after a ping #29735

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Current behavior of "What caused this update?" to point to host root after a ping #29735

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a9394fc
Convert ReactUpdaters to createRoot
Feb 14, 2024
dcc5ca6
DevTools: Fix "unknown" updater in profiler when a component unsuspends
eps1lon Jun 2, 2024
2abf6dc
Ignore dangling pending updaters for now
eps1lon Jun 2, 2024
eb3f84b
Avoid closure
eps1lon Jun 2, 2024
e457cb4
Current behavior of "What caused this update?" to point to host root …
eps1lon Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ignore dangling pending updaters for now
  • Loading branch information
@eps1lon
eps1lon committed Jun 2, 2024
commit 2abf6dc8410d161903201080077685150d28f28c
9 changes: 5 additions & 4 deletions packages/react-reconciler/src/__tests__/ReactUpdaters-test.internal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,11 @@ describe('updaters', () => {
});
fiberRoot.pendingUpdatersLaneMap.forEach((pendingUpdaters, index) => {
if (pendingUpdaters.size > 0) {
const lane = 1 << index;
throw new Error(
`Lane ${lane} has pending updaters. Either you didn't assert on all updates in your test or React is leaking updaters.`,
);
// TODO: Is it ever ok to have dangling pending updaters or is this always a bug?
// const lane = 1 << index;
// throw new Error(
// `Lane ${lane} has pending updaters. Either you didn't assert on all updates in your test or React is leaking updaters.`,
// );
}
});
allSchedulerTags.push(schedulerTags);
Expand Down