Current behavior of "What caused this update?" to point to host root after a ping #29735
+109
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes
````
SyntaxError: ~/react/packages/react-reconciler/src/ReactFiberLane.js: Compiling let/const in this block would add a closure (throwIfClosureRequired).
614 | if (updateLane !== IdleLane) {
615 | if (enableUpdaterTracking) {
> 616 | if (isDevToolsPresent) {
| ^
617 | // transfer pending updaters from pingedLanes to updateLane
618 | const pendingUpdatersLaneMap = root.pendingUpdatersLaneMap;
619 | const updaters = pendingUpdatersLaneMap[laneToIndex(updateLane)];
```
…when lazy resolves
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Comparing: d77dd31...e457cb4 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
eps1lon
commented
Jun 5, 2024
Comment on lines
+448
to
450
| // TODO: If this was a single commit, ErrorBoundary shouldn't be in here. | ||
| // We only set state in Parent so that should be the only updater | ||
| expect(allSchedulerTypes).toEqual([[Parent], [ErrorBoundary]]); |
There was a problem hiding this comment.
ErrorBoundary does make sense I believe. It's kind of like a rerender triggered from a child. Though just like the Fiber isn't generally sufficient information for setState updates, the error boundary isn't generally sufficient for "rerenders" due to errors. You'd want the boundary + the origin of the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #28330
It seems like we always use the updater that triggered the wakeable to be considered the updater on the ping. That is confusing IMO. The ping should be the updater. Some dirty fixes revealed other oddities with error boundaries.
Might revisit this in the future if we're still bought into updater tracking