Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set MIT license in package.json transform #919

Merged
merged 2 commits into from
Nov 30, 2021
Merged

fix: set MIT license in package.json transform #919

merged 2 commits into from
Nov 30, 2021

Conversation

erickzhao
Copy link
Member

No description provided.

@erickzhao erickzhao requested review from malept and a team November 30, 2021 19:41
malept
malept approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit. Do we have tests for the transform?

@erickzhao
Copy link
Member Author

Yep, and I forgot to update them in the initial commit. See 3c10928

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 93.033% when pulling 3c10928 on fix/MIT-license into b766aae on master.

@erickzhao erickzhao merged commit 578436c into master Nov 30, 2021
@erickzhao erickzhao deleted the fix/MIT-license branch November 30, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malept malept malept approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erickzhao @coveralls @malept