Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: defaultPath should apply on all dialog types in Linux Portal #42655

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix: defaultPath should apply on all dialog types in Linux Portal #42655

merged 1 commit into from
Jun 27, 2024

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jun 26, 2024 •
edited by deepak1556
Loading

Description of Change

Refs microsoft/vscode#213780.

Fixes an issue where the user-specified default path did not take the expected effect when using XDG Portal unless the user was using a save dialog.

This was happening because Chromium's XDG Portal dialog implementation only set the default path in a save dialog context. Fix this by taking it into account for all dialog types.

Checklist

Release Notes

Notes: Fixes an issue where the user-specified default path did not work in some circumstances when using Linux dialogs.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/29-x-y PR should also be added to the "29-x-y" branch. target/30-x-y PR should also be added to the "30-x-y" branch. target/31-x-y PR should also be added to the "31-x-y" branch. target/32-x-y PR should also be added to the "32-x-y" branch. labels Jun 26, 2024
@codebytere codebytere requested a review from a team as a code owner June 26, 2024 07:39
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 26, 2024
deepak1556
deepak1556 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 27, 2024
@codebytere codebytere merged commit c628de5 into main Jun 27, 2024
69 of 71 checks passed
@codebytere codebytere deleted the fix-default-path-portal branch June 27, 2024 09:07
@release-clerk Release Clerk
Copy link

release-clerk bot commented Jun 27, 2024

Release Notes Persisted

Fixes an issue where the user-specified default path did not work in some circumstances when using Linux dialogs.

@trop
Copy link
Contributor

trop bot commented Jun 27, 2024

I was unable to backport this PR to "29-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jun 27, 2024

I was unable to backport this PR to "31-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/29-x-y PR should also be added to the "29-x-y" branch. label Jun 27, 2024
@trop
Copy link
Contributor

trop bot commented Jun 27, 2024

I was unable to backport this PR to "30-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/29-x-y and removed target/31-x-y PR should also be added to the "31-x-y" branch. labels Jun 27, 2024
@trop trop bot mentioned this pull request Jun 27, 2024
Merged
@trop trop bot added needs-manual-bp/31-x-y needs-manual-bp/30-x-y and removed target/30-x-y PR should also be added to the "30-x-y" branch. labels Jun 27, 2024
@trop
Copy link
Contributor

trop bot commented Jun 27, 2024

I have automatically backported this PR to "32-x-y", please check out #42680

@trop trop bot added in-flight/32-x-y merged/32-x-y PR was merged to the "32-x-y" branch. and removed target/32-x-y PR should also be added to the "32-x-y" branch. in-flight/32-x-y labels Jun 27, 2024
@codebytere codebytere mentioned this pull request Jun 27, 2024
Merged
@trop
Copy link
Contributor

trop bot commented Jun 27, 2024

@codebytere has manually backported this PR to "31-x-y", please check out #42685

@codebytere codebytere mentioned this pull request Jun 27, 2024
Merged
@trop
Copy link
Contributor

trop bot commented Jun 27, 2024

@codebytere has manually backported this PR to "30-x-y", please check out #42687

@trop trop bot added in-flight/30-x-y merged/31-x-y PR was merged to the "31-x-y" branch. merged/30-x-y PR was merged to the "30-x-y" branch. and removed needs-manual-bp/30-x-y in-flight/31-x-y in-flight/30-x-y labels Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
merged/30-x-y PR was merged to the "30-x-y" branch. merged/31-x-y PR was merged to the "31-x-y" branch. merged/32-x-y PR was merged to the "32-x-y" branch. needs-manual-bp/29-x-y semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @deepak1556