Skip to content

docs: add workaround for torch compile #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 29, 2023
Merged

docs: add workaround for torch compile #1754

merged 12 commits into from
Aug 29, 2023

Conversation

JohannesMessner
Copy link
Member

@JohannesMessner JohannesMessner commented Aug 15, 2023

fixing torch compilation with TorchTensor is blocked by upstream (see here: #1753), so i'm adding workaround to the docs.

Torch 2.0.1 and poetry don't seem to like each other (see: https://stackoverflow.com/a/76647180) so i had to introduce a bunch of pip uninstall torch / pip install torch to make torch work on the CI.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.25% 🎉

Comparison is base (587ab5b) 83.74% compared to head (374abbd) 84.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1754      +/-   ##
==========================================
+ Coverage   83.74%   84.99%   +1.25%     
==========================================
  Files         134      134              
  Lines        8845     8845              
==========================================
+ Hits         7407     7518     +111     
+ Misses       1438     1327     -111     
Flag Coverage Δ
docarray 84.99% <ø> (+1.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
docarray/typing/tensor/torch_tensor.py 91.08% <ø> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/m and removed size/s labels Aug 15, 2023
Signed-off-by: Johannes Messner <[email protected]>
@JohannesMessner JohannesMessner marked this pull request as ready for review August 29, 2023 06:59
@github-actions
Copy link

📝 Docs are deployed on https://ft-docs-torch-compile--jina-docs.netlify.app 🎉

@samsja samsja merged commit cd4854c into main Aug 29, 2023
@samsja samsja deleted the docs-torch-compile branch August 29, 2023 07:19
@JoanFM JoanFM mentioned this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document torch.compile workaround
2 participants