Skip to content

fix: fix torch compilation #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: fix torch compilation #1753

wants to merge 1 commit into from

Conversation

JohannesMessner
Copy link
Member

@JohannesMessner JohannesMessner commented Aug 14, 2023

Attempting to fix torch compilation with docarray TorchTensors.

closes #1269

@JohannesMessner JohannesMessner changed the title fix: misc stuff to fix torch compilation fix: fix torch compilation Aug 14, 2023
@github-actions
Copy link

📝 Docs are deployed on https://ft-fix-torch-compile--jina-docs.netlify.app 🎉

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -6.00% ⚠️

Comparison is base (6c77112) 83.60% compared to head (a440e16) 77.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1753      +/-   ##
==========================================
- Coverage   83.60%   77.60%   -6.00%     
==========================================
  Files         134      134              
  Lines        8842     8840       -2     
==========================================
- Hits         7392     6860     -532     
- Misses       1450     1980     +530     
Flag Coverage Δ
docarray 77.60% <100.00%> (-6.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
docarray/typing/tensor/torch_tensor.py 86.86% <100.00%> (-4.23%) ⬇️

... and 54 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohannesMessner
Copy link
Member Author

We might be blocked on this: pytorch/pytorch#105167

@JohannesMessner
Copy link
Member Author

Closing because blocked by upstream

@JohannesMessner
Copy link
Member Author

Seems like this is unblocked now: pytorch/pytorch#106378 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: torch 2.x with TorchTensor
1 participant