Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #31840 - Added Support for Cross-Origin Opener Policy #13351

Closed
wants to merge 2 commits into from

Conversation

meggles711
Copy link
Contributor

Implemented support for cross-origin opener policy. Fixes #31840

@meggles711 meggles711 force-pushed the master branch 2 times, most recently from 560ce96 to 6ea081d Compare August 31, 2020 19:52
Copy link
Sponsor Member

@adamchainz adamchainz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, amazing for a first time contribution. Thank you for making this PR - I love to see new security headers coming into Django. I was a bit concerned that browsers might not have standardized MDN lists the header as fully supported on Chrome, Edge, and Firefox.

The new default is backwards incompatible, but I think the use cases (cross-site pop-ups deliberately communicating) are fairly niche (I think?). For referrer-policy we added it in one version (3.0) then changed the default in the next (3.1.). We could do that here, but I think doing it all at once with a good release note should be enough, and isn't really that functionally different from changing the default in one version.

I've made a few comments below, mostly small picks. I'm sure the fellows will have more to say, they know more about what's going on than me.

I didn't check but there should be a ticket for COEP/CORP too, if you're feeling like a follow-up. I guess they should be added together since they're more interdependent.

django/conf/global_settings.py Show resolved Hide resolved
django/middleware/security.py Show resolved Hide resolved
django/middleware/security.py Show resolved Hide resolved
docs/ref/checks.txt Show resolved Hide resolved
docs/ref/middleware.txt Show resolved Hide resolved
docs/ref/settings.txt Show resolved Hide resolved
docs/releases/3.2.txt Show resolved Hide resolved
docs/topics/security.txt Show resolved Hide resolved
docs/topics/security.txt Show resolved Hide resolved
django/core/checks/security/base.py Show resolved Hide resolved
Base automatically changed from master to main March 9, 2021 06:21
Copy link
Member

@timgraham timgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't push to this branch so I addressed all review comments and made a few more edits of my own in #14189.

django/core/checks/security/base.py Show resolved Hide resolved
@timgraham timgraham closed this Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants