Fix config targets #1673
Merged
Fix config targets #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenBirt
approved these changes
Feb 7, 2024
core/utils.ts
Outdated
Comment on lines
263
to
265
| name: actionConfigTarget.name, | ||
| schema: actionConfigTarget.dataset, | ||
| database: actionConfigTarget.project |
There was a problem hiding this comment.
This would add the dataset and project fields to the proto object, which even though they're not fields, is valid in protobufjs objects
|
|
||
| const result = runMainInVm(coreExecutionRequestFromPath(projectDir)); | ||
|
|
||
| expect(result.compile.compiledGraph.graphErrors.compilationErrors).deep.equals([]); |
There was a problem hiding this comment.
this seems like a pretty weak assertion - dependency targets could be completely ignored by compilation, and this would still be true
There was a problem hiding this comment.
Have added more tests
The class constructor is the builder for action configs - it's large at the moment because I want to split out view and incrementalTable into separate classes (soon). |
moker-spaghetti
pushed a commit
to moker-spaghetti/dataform
that referenced
this pull request
May 26, 2024
* Fix config targets * Fix lint * Add more tests, fix fully qualified dependencies for notebooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.