Remove warehouse option from the CLI, more tidying #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenBirt
approved these changes
Jan 18, 2024
| "The default database to use. For BigQuery, this is a Google Cloud Project ID." | ||
| describe: "The default database to use, equivalent to Google Cloud Project ID." | ||
| }, | ||
| check: (argv: yargs.Arguments<any>) => { |
There was a problem hiding this comment.
do you actually need this? i'm pretty sure yargs fails without all positional arguments specified.
There was a problem hiding this comment.
I played around with this, I was surprised that it didn't fail by default either - maybe after a version bump it will
There was a problem hiding this comment.
It definitely does fail without positional arguments:
➜ dataform init
Dataform encountered an error: Not enough non-option arguments: got 0, need at least 1
Dataform encountered an error: Missing required argument: warehouse
cli/index.ts
Outdated
| @@ -477,15 +473,13 @@ export function runCli() { | |||
| }, | |||
| { | |||
| format: `run [${projectDirMustExistOption.name}]`, | |||
| description: "Run the dataform project's scripts on the configured data warehouse.", | |||
| description: "run the dataform project.", | |||
cli/index.ts
Outdated
| format: `listtables <${ProjectConfigOptions.warehouse.name}>`, | ||
| description: "List tables on the configured data warehouse.", | ||
| positionalOptions: [ProjectConfigOptions.warehouse], | ||
| format: `listtables`, |
There was a problem hiding this comment.
up to you but: i think we should get rid of these CLI commands, i bet they are effectively never used
moker-spaghetti
pushed a commit
to moker-spaghetti/dataform
that referenced
this pull request
May 26, 2024
* Remove warehouse option from the CLI, more tidying * Fix default db location requirement * Make default location and database positional for init * Fix import order * Remove some unused CLI commands, tidy * Remove unused finally block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.