Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better errors for invalid declarations, add more test coverage #1637

Merged
merged 5 commits into from
Jan 4, 2024

Conversation

Ekrekr
Copy link
Contributor

@Ekrekr Ekrekr commented Jan 4, 2024

No description provided.

@Ekrekr Ekrekr requested a review from BenBirt January 4, 2024 14:15
core/compilers.ts Outdated Show resolved Hide resolved
core/compilers.ts Outdated Show resolved Hide resolved
@Ekrekr Ekrekr requested a review from BenBirt January 4, 2024 16:20
core/compilers.ts Outdated Show resolved Hide resolved
core/compilers.ts Outdated Show resolved Hide resolved
@Ekrekr Ekrekr merged commit e925197 into main_v3 Jan 4, 2024
4 checks passed
@Ekrekr Ekrekr deleted the improve-filename-experience branch January 4, 2024 17:50
moker-spaghetti pushed a commit to moker-spaghetti/dataform that referenced this pull request May 26, 2024
…orm-co#1637)

* Add more tests, throw better errors for invalid declaration action configs

* Make file compiler loaders not functions

* Tidy

* Move notebook cell stripping and compile json to main

* Tidy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants