Add basic support for actions.yaml reading SQL files as operations #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, to preserve JS API compatability
tatianaschmidt
requested changes
Jan 2, 2024
tatianaschmidt
approved these changes
Jan 2, 2024
moker-spaghetti
pushed a commit
to moker-spaghetti/dataform
that referenced
this pull request
May 26, 2024
…ataform-co#1628) * Experiment with basic SQL file support * Fix canonical target population and tidy test * Add proof of context to test * Tidy * Make the action additions to the session use the JS session interface, to preserve JS API compatability * Fix bug with action target names * Fix tslint errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Javascript context in the SQL file is preserved.
The javascript API for adding operations to the session is extended to accept the full action config proto as an option, instead of just the name.