Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move common target constructor methods to the action builder #1626

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Move common target constructor methods to the action builder #1626

merged 2 commits into from
Dec 29, 2023

Conversation

Ekrekr
Copy link
Contributor

@Ekrekr Ekrekr commented Dec 28, 2023 •
edited

Facilitate this by making the action builder an abstract class.

This makes migrating the existing SQL action types to using the protobuf config types easier.

@Ekrekr Ekrekr changed the title Move common target constructor methods to the action build, and make … Move common target constructor methods to the action builder Dec 28, 2023
@Ekrekr Ekrekr merged commit cab2195 into main_v3 Dec 29, 2023
4 checks passed
@Ekrekr Ekrekr deleted the config-proto-session-constructors branch December 29, 2023 11:01
moker-spaghetti pushed a commit to moker-spaghetti/dataform that referenced this pull request May 26, 2024
@Ekrekr
Move common target constructor methods to the action builder (datafor…
84b453a 
…m-co#1626)

* Move common target constructor methods to the action build, and make the action builder an abstract class

* Add missing public access modifiers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maverickjoy maverickjoy maverickjoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ekrekr @maverickjoy