Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move custom variables test to the new testing structure #1601

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Move custom variables test to the new testing structure #1601

merged 3 commits into from
Dec 4, 2023

Conversation

Ekrekr
Copy link
Contributor

@Ekrekr Ekrekr commented Dec 4, 2023 •
edited

This includes testing the functionality for workflow_settings.yaml too.

Unfortunately we can't do this automatically do this with verifyObjectMatchesProto because ProtobufJS doesn't care whether protobuf fields are strings or numbers.

@Ekrekr Ekrekr merged commit 35bf7a3 into main_v3 Dec 4, 2023
4 checks passed
@Ekrekr Ekrekr deleted the add-test-for-var-usage branch December 4, 2023 14:03
moker-spaghetti pushed a commit to moker-spaghetti/dataform that referenced this pull request May 26, 2024
@Ekrekr
Move custom variables test to the new testing structure (dataform-co#…
362e85e 
…1601)

* Update tests for custom variables to new structure, enforce it for workflow_settings.yaml too

* Tidy

* Fix tslint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diasdauletov diasdauletov diasdauletov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ekrekr @diasdauletov