Move core/tasks.ts to CLI, and minor cleanup #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maverickjoy
reviewed
Dec 4, 2023
| /** | ||
| * Provides a readable string representation of the target which is used for e.g. specifying | ||
| * actions on the CLI. | ||
| * This is effectively equivelant to an action "name". | ||
| * | ||
| * This is an ambiguous transformation, multiple targets may map to the same string | ||
| * and it should not be used for indexing. Use {@code targetStringifier} instead. | ||
| * | ||
| * TODO(ekrekr): replace remaining incorrect usage of this with targetStringifier. |
There was a problem hiding this comment.
Maybe create an internal bug for tracking ?
There was a problem hiding this comment.
I will do this as part of the v3 release bug (we're not meant to link buganizer in open source).
maverickjoy
approved these changes
Dec 4, 2023
moker-spaghetti
pushed a commit
to moker-spaghetti/dataform
that referenced
this pull request
May 26, 2024
* Move tasks.ts to CLI, and minor cleanup * Fix imports * Fix API test * Fix import order * Add missing build rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.