Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using ProtobufJS's verify method (it doesn't do much) #1596

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Stop using ProtobufJS's verify method (it doesn't do much) #1596

merged 4 commits into from
Dec 1, 2023

Conversation

Ekrekr
Copy link
Contributor

@Ekrekr Ekrekr commented Dec 1, 2023

No description provided.

@Ekrekr Ekrekr changed the title Stop using ProtobufJS's verify method because it doesn't do anything Stop using ProtobufJS's verify method (it doesn't do much) Dec 1, 2023
@Ekrekr Ekrekr requested a review from a2wd December 1, 2023 11:06
a2wd
a2wd reviewed Dec 1, 2023
View reviewed changes
common/protos/index.ts Outdated Show resolved Hide resolved
@Ekrekr Ekrekr requested a review from a2wd December 1, 2023 11:39
@Ekrekr Ekrekr merged commit e7e9c09 into main_v3 Dec 1, 2023
4 checks passed
@Ekrekr Ekrekr deleted the fix-compile-validation branch December 1, 2023 11:53
moker-spaghetti pushed a commit to moker-spaghetti/dataform that referenced this pull request May 26, 2024
@Ekrekr
Stop using ProtobufJS's verify method (it doesn't do much) (dataform-…
76c64f7 
…co#1596)

* Stop using ProtobufJS's verify method because it doesn't really do anything

* Fix proto validation and tests

* Remove buganizer reference

* Fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a2wd a2wd a2wd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ekrekr @a2wd