Validate workflow settings fields #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenBirt
approved these changes
Nov 21, 2023
| @@ -14,6 +14,33 @@ export interface IProtoClass<IProto, Proto> { | |||
| fromObject(obj: { [k: string]: any }): Proto; | |||
| } | |||
|
|
|||
| // ProtobufJS's native verify method does not check that only defined fields are present. | |||
| // TODO(ekrekr): swap to Typescript protobuf library rather than having to do this. | |||
| export function verifyObjectMatchesProto<Proto>( | |||
There was a problem hiding this comment.
i hate this, let's please switch
There was a problem hiding this comment.
I did some digging into this, and the alternatives which can validate (https://www.npmjs.com/package/@protobuf-ts/plugin, https://www.npmjs.com/package/protoc-gen-ts) are significantly slower. More details in b/305915462#comment18.
moker-spaghetti
pushed a commit
to moker-spaghetti/dataform
that referenced
this pull request
May 26, 2024
* Add workflow settings validation * Tidy * Remove return from recursive field check * Fix object lint error * Remove braking run cache option from CLI * Remove console log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include a generic best effort Protobuf field validator.