Deprecate support for old type .sql files
#1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewish
reviewed
Nov 1, 2023
There was a problem hiding this comment.
I think we should keep this test, but I would remove all the old SQL files, and bump the core version to something more recent that we do want to continue to support (probably 2.0.0) and add some basic SQLX files in here.
The purpose of this test is partially to make sure we don't break the compilation "contract" between the old versions of core and the new versions of the CLI, which is still valuable IMO.
aa9913c
to
3a7bedc
Compare
lewish
approved these changes
Nov 1, 2023
moker-spaghetti
pushed a commit
to moker-spaghetti/dataform
that referenced
this pull request
May 26, 2024
* Deprecate support for old type .sql files * Re-add backwards compatability test, with explanatory comment * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.