Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate cli package #1557

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Consolidate cli package #1557

merged 2 commits into from
Oct 26, 2023

Conversation

Ekrekr
Copy link
Contributor

@Ekrekr Ekrekr commented Oct 26, 2023

Move the Dataform API and VM packages under the CLI, as that's what uses them

@Ekrekr Ekrekr requested a review from lewish October 26, 2023 12:35
@Ekrekr Ekrekr changed the base branch from main to main_v3 October 26, 2023 12:35
Copy link
Collaborator

@lewish lewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this was a common source of confusion!

@Ekrekr Ekrekr merged commit 73e1f0b into main_v3 Oct 26, 2023
4 checks passed
@Ekrekr Ekrekr deleted the consolidate-cli-package branch October 26, 2023 14:29
Ekrekr added a commit that referenced this pull request Oct 27, 2023
* Consolidate CLI package by moving API and VM directories under it

* Fix import order
moker-spaghetti pushed a commit to moker-spaghetti/dataform that referenced this pull request May 26, 2024
* Consolidate CLI package by moving API and VM directories under it

* Fix import order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants