fix: debug logs in server #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpacker
pushed a commit
that referenced
this pull request
Jun 17, 2024
Co-authored-by: Ethan Knox <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request.
This exposes log messages from the MemGPT logger (and children) in the server log stream.
By default INFO + will be displayed, set
MEMGPT_DEBUGto add debug logs to the stream too.MEMGPT_DEBUGfalse or not setMEMGPT_DEBUGtrueHow to test
Have you tested this PR? ✅
Is your PR over 500 lines of code?
This is turning out to be an excellent gateway for the config work we've discussed. I am going to piggyback a second PR off this one that will marry the rest of the constants into the settings singleton next, which was started in this PR with the MEMGPT_DIR envar.
Additional context
We will want a milder logging config for non-development eventually, but since this is on par with how logging was set up already and there are bigger fish to fry, I just named it DEVELOPMENT_LOGGING to remind us that we need a prod version.
I removed the logging tests because they were basically testing Python logging, which is Python's job not ours 😉
There was a log that printed the auth key/password - I didn't want to leave that in there so I updated.