feat: make readinessProbe and livenessProbe initialDelaySeconds configurable #18756
+106
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gurable Adds configurable initialDelaySeconds for readinessProbe and livenessProbe in the Helm chart values.yaml and updates the _coder.tpl template to use these values. Defaults to 0 seconds to maintain existing behavior. Co-authored-by: kylecarbs <[email protected]>
Updates all helm chart test golden files to include the new initialDelaySeconds: 0 configuration for readiness and liveness probes. Co-authored-by: kylecarbs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
initialDelaySecondsconfigurable for bothreadinessProbeandlivenessProbein the Helm chartChanges:
coder.readinessProbe.initialDelaySecondsandcoder.livenessProbe.initialDelaySecondstovalues.yaml_coder.tpltemplate to use these configurable valuesTesting:
initialDelaySeconds