Skip to content

feat: make readinessProbe and livenessProbe initialDelaySeconds configurable #18756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

feat: make readinessProbe and livenessProbe initialDelaySeconds configurable #18756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a530783
feat: make readinessProbe and livenessProbe initialDelaySeconds confi…
blink-so[bot] Jul 4, 2025
712a405
test: update helm test golden files for probe initialDelaySeconds
blink-so[bot] Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions helm/coder/templates/_coder.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,11 @@ readinessProbe:
path: /healthz
port: "http"
scheme: "HTTP"
initialDelaySeconds: {{ .Values.coder.readinessProbe.initialDelaySeconds }}
livenessProbe:
httpGet:
path: /healthz
port: "http"
scheme: "HTTP"
initialDelaySeconds: {{ .Values.coder.livenessProbe.initialDelaySeconds }}
{{- end }}
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/auto_access_url_1.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -181,6 +182,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/auto_access_url_1_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -181,6 +182,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/auto_access_url_2.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -181,6 +182,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/auto_access_url_2_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -181,6 +182,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/auto_access_url_3.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/auto_access_url_3_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/command.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/command_args.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -180,6 +181,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/command_args_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -180,6 +181,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/command_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/custom_resources.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 4000m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/custom_resources_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 4000m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/default_values.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/default_values_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/env_from.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -191,6 +192,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/env_from_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -191,6 +192,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/extra_templates.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -188,6 +189,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/extra_templates_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -188,6 +189,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/labels_annotations.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -187,6 +188,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/labels_annotations_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -187,6 +188,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/partial_resources.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
requests:
cpu: 1500m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/partial_resources_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
requests:
cpu: 1500m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/prometheus.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -183,6 +184,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
Expand Down
2 changes: 2 additions & 0 deletions helm/coder/tests/testdata/prometheus_coder.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
Expand All @@ -183,6 +184,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
Expand Down
Loading
Loading