Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development BUG - Fixes launcher overwriting or not backing up terminal emulator settings in development branch. #2945

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Development BUG - Fixes launcher overwriting or not backing up terminal emulator settings in development branch. #2945

wants to merge 1 commit into from

Conversation

daxgames
Copy link
Member

@daxgames daxgames commented May 31, 2024 •
edited
Loading

Added below after comparing to working code in master:

Note: Line numbers are from the PR Code not the original code

297 if (PathFileExists(cfgPath))
298 {
299-338 indent <original code>
339 }

Removed ** code ** below after comparing to working code in master:

Note: Line numbers are from the PR Code not the original code

293 <original code> **wcscmp(cpuCfgPath, L"") == 0 &&** <original code>
338 <original code> **wcscmp(userCfgPath, L"") == 0 &&** <original code>
443 <original code> **wcscmp(cfgPath, L"") == 0 &&** <original code>

Everything else is a comment or a { bracket line change

@daxgames
Copy link
Member Author

daxgames commented May 31, 2024 •
edited
Loading

I have tested this code and it works using the following reproduction steps:

How to validate the fix.

  1. Download and extract conemu and windows terminal artifacts built by this PR.
  2. Run cmder.exe for each artifact is being tested
  3. Validate default tasks/profiles are present.
  4. Edit/Add a profile/task in Windows Terminal or ConEmu depending which artifact is being tested
  5. Close Windows Terminal or ConEmu depending which artifact is being tested
  6. Run cmder.exe for each artifact is being tested
  7. Profile Edits/Adds are still present.
  8. Exit ConEmu /Windows Terminal depending which artifact is being tested
  9. Delete Terminal emulator settings files for conemu(conemu.xml) and windows terminal(settings.json)
  10. Run cmder.exe for each artifact is being tested
  11. Validate your edited tasks/profiles are present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DRSDavidSoft DRSDavidSoft Awaiting requested review from DRSDavidSoft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@daxgames