Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Cannot drag links onto Chromium's icon #209

Open
gpsvisualizer opened this issue Feb 27, 2024 · 5 comments
Open

[BUG] Cannot drag links onto Chromium's icon #209

gpsvisualizer opened this issue Feb 27, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@gpsvisualizer
Copy link

If Chromium Legacy is NOT set as my default browser, and I try to drag a link from another browser (Chrome, Waterfox, or Firefox) onto Chromium Legacy's Dock icon, it does not open in Chromium; it opens in the default browser.

If Chromium Legacy IS set as my default browser, and I try to drag a link from another browser onto Chromium Legacy's Dock icon, it STILL does not open in Chromium Legacy; Chromium is brought to the front, but the link is not opened.

Mac OS version: Yosemite 10.10.5
Chromium version: 123.0.6303.0 (but the same problem occurs in v122 as well)
@gpsvisualizer gpsvisualizer added the bug Something isn't working label Feb 27, 2024
@Wowfunhappy
Copy link
Sponsor

Can confirm this in Mavericks. Issue occurs starting in Chromium Legacy 121.

@CatsLover2006
Copy link

Can confirm on Lion, seems to be an issue with console arguments. I'm going to downgrade to 120.0.6099.199.1 until this is fixed; this breaks one of my other applications.

@Wowfunhappy
Copy link
Sponsor

Wowfunhappy commented Mar 9, 2024 •
edited
Loading

For reference, we ran into this bug before: #68

All the symptoms are the same. In addition to not being able to drag links into Chromium's icon, Chromium also cannot open links from other apps, or local .html or .webloc files.

This bug was previously fixed in a9efda1

It looks like the apple event handlers are once again missing from https://github.com/blueboxd/chromium-legacy/blob/master.lion/chrome/browser/app_controller_mac.mm, which is presumably causing the bug.

@Wowfunhappy
Copy link
Sponsor

Wowfunhappy commented Mar 18, 2024 •
edited
Loading

It looks like we just need to add three lines back to mainMenuCreated:

NSAppleEventManager* em = [NSAppleEventManager sharedAppleEventManager];
[em setEventHandler:self andSelector:@selector(getUrl:withReply:) forEventClass:kInternetEventClass andEventID:kAEGetURL];
[em setEventHandler:self andSelector:@selector(getUrl:withReply:) forEventClass:'WWW!' andEventID:'OURL'];

Adding these via code injection swizzling fixes the bug.

Note that the equivalent cleanup lines are already present in unregisterEventHandlers.

@Wowfunhappy
Copy link
Sponsor

This bug is fixed in the most recent version of #25

blueboxd pushed a commit that referenced this issue May 16, 2024
Roll Chrome Win32 PGO Profile
4433307 
Roll Chrome Win32 PGO profile from chrome-win32-6367-1711339532-72d4729d77e1920a69e0808a351ae1ef44d11319-86072a8a4ae2686ab42b026a94b7aeeb8ed1b235.profdata to chrome-win32-6367-1711366904-d96ae799efb7b02632e00a72f44d229d3133fddc-c055d4ed29a25eb8dd7d7cb23be90527690440b5.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m124.try:win-chrome
Tbr: [email protected]
Change-Id: I4088f2c54326c719381cff826130a75b4b0cef11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5391355
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/6367@{#209}
Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Wowfunhappy @gpsvisualizer @CatsLover2006