Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version vandidate 0.4.0 — upgrade Rubies + Setup #77

Merged
merged 8 commits into from
Aug 4, 2020
Merged

Version vandidate 0.4.0 — upgrade Rubies + Setup #77

merged 8 commits into from
Aug 4, 2020

Conversation

kigster
Copy link
Contributor

@kigster kigster commented Jul 29, 2020 •
edited
Loading

  • Upgraded the default Ruby version to 2.7.1
  • Adding a bin/clean script
  • Fixing a bunch of setup errors
  • Upgrading Bazel version, and OS-X brew-based setup
  • Upgrading rbenv/ruby-build and adding a proper rbenv installation if not there already
  • Adding more Ruby versions to the list of accepted local versions
  • Fixing a bug in a bin/linter

@kigster kigster requested a review from yugui as a code owner July 29, 2020 22:14
@kigster kigster self-assigned this Jul 29, 2020
@kigster kigster force-pushed the kig/v0.4.0-candidate branch 4 times, most recently from 4837537 to 22807b7 Compare August 4, 2020 21:44
kigster
kigster commented Aug 4, 2020
View reviewed changes
Copy link
Contributor Author

@kigster kigster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR mostly upgrades dependencies and improves on the scripts that build and test.

@kigster kigster merged commit c449402 into develop Aug 4, 2020
@kigster kigster deleted the kig/v0.4.0-candidate branch August 4, 2020 22:55
lalten
lalten reviewed Nov 4, 2020
View reviewed changes
ruby/private/sdk.bzl
Comment on lines +16 to +17
"2.7.1",
"2.7.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this intentional? Guessing this should be "2.7.0", "2.7.1",?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalten lalten lalten left review comments

@yugui yugui Awaiting requested review from yugui yugui is a code owner

Assignees

@kigster kigster

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kigster @lalten