Correctly restore upstream_task_ids when deserializing Operators #8775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
commented
May 7, 2020
| delete_bucket_1 = GCSDeleteBucketOperator(task_id="delete_bucket", bucket_name=BUCKET_1) | ||
| delete_bucket_2 = GCSDeleteBucketOperator(task_id="delete_bucket", bucket_name=BUCKET_2) | ||
| delete_bucket_1 = GCSDeleteBucketOperator(task_id="delete_bucket_1", bucket_name=BUCKET_1) | ||
| delete_bucket_2 = GCSDeleteBucketOperator(task_id="delete_bucket_2", bucket_name=BUCKET_2) |
6 tasks
|
Tested this PR fixes #8720 :
|
This test exposed a bug in one of the example dags, that wasn't caught by apache#6549. That will be a fixed in a separate issue, but it caused the round-trip tests to fail here Fixes apache#8720
d3defcf
to
0618800
Compare
ashb
added a commit
to astronomer/airflow
that referenced
this pull request
May 18, 2020
…che#8775) This test exposed a bug in one of the example dags, that wasn't caught by apache#6549. That will be a fixed in a separate issue, but it caused the round-trip tests to fail here Fixes apache#8720 (cherry picked from commit 280f1f0)
kaxil
pushed a commit
that referenced
this pull request
Jun 26, 2020
potiuk
pushed a commit
that referenced
this pull request
Jun 29, 2020
kaxil
pushed a commit
that referenced
this pull request
Jul 1, 2020
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
…che#8775) This test exposed a bug in one of the example dags, that wasn't caught by apache#6549. That will be a fixed in a separate issue, but it caused the round-trip tests to fail here Fixes apache#8720 (cherry picked from commit 280f1f0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test exposed a bug in one of the example dags, that wasn't caught by #6549. That will be a fixed in a separate issue, but it caused the round-trip tests to fail here
Fixes #8720
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.