Skip to content

fix: correct JWT secret name to match deployment environment #52268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2025

Conversation

junminahn
Copy link
Contributor

This PR fixes a Kubernetes deployment error (CreateContainerConfigError) caused by a mismatch in the JWT secret name.

The issue stems from inconsistent prefixes used when referencing the secret:

  • In the deployment environment, the JWT secret is referenced using the jwt_secret variable derived from .Release.Name.
  • However, the actual secret was created using the airflow.fullname variable.

This mismatch led to the deployment failing to locate the expected secret.
To resolve this, the secret name has been updated to also use the jwt_secret variable, ensuring consistency between the secret's name and how it's referenced in the deployment.

References

Copy link

boring-cyborg bot commented Jun 25, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Jun 25, 2025
@albundy83
Copy link

Hello,

it could also be:

{{- define "jwt_secret" -}}
  {{- default (printf "%s-jwt_secret" (include "airflow.fullname" .)) .Values.jwtSecretName }}
{{- end }}

As defined for webserver_secret_key_secret:

@junminahn
Copy link
Contributor Author

Hello,

it could also be:

{{- define "jwt_secret" -}}
  {{- default (printf "%s-jwt_secret" (include "airflow.fullname" .)) .Values.jwtSecretName }}
{{- end }}

As defined for webserver_secret_key_secret:

That works too, but my main intention is to reuse the same variable jwt_secret, defined in the helper file, in both the deployment and secret files to ensure consistency in the secret name. We can discuss the best way to define the variable separately, whether it's using airflow.fullname or .Release.Name.

@jedcunningham
Copy link
Member

@junminahn can you also fix the failing test, as the name has been fixed now? Thanks.

@junminahn
Copy link
Contributor Author

@junminahn can you also fix the failing test, as the name has been fixed now? Thanks.

I've updated the test file as needed. Could you please approve the pending workflows?

@junminahn
Copy link
Contributor Author

@jedcunningham Thanks for approving the workflows; all checks are passing now. Would you mind merging this PR? Appreciate it!

@jedcunningham jedcunningham merged commit f6b0e4b into apache:main Jun 27, 2025
68 checks passed
Copy link

boring-cyborg bot commented Jun 27, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@jedcunningham
Copy link
Member

Thanks @junminahn! Congrats on your first commit 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants